Skip to content

Conversation

@sw-joelmut
Copy link
Collaborator

Fixes #4545

Description

This PR migrates the use of zod 1.11.17 to ^3.22.4 to avoid ReDoS vulnerability.

Specific Changes

  • Updated zod version to ^3.22.4 in
    • botbuilder-dialogs-adaptive-runtime
    • botbuilder-dialogs-adaptive-runtime-integration-azure-functions
    • botbuilder-dialogs-adaptive-runtime-integration-express
    • botbuilder-dialogs-adaptive-runtime-integration-restify
    • botbuilder-dialogs-adaptive-testing
    • botbuilder-dialogs-declarative
    • botbuilder-dialogs
  • Replaced use of check method with safeParse.

Testing

The following image shows some bot samples working after the update.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 8, 2023 14:33
@tracyboehrer tracyboehrer merged commit 6abfddf into main Nov 9, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/zod-botbuilder-dialogs branch November 9, 2023 01:57
@tracyboehrer tracyboehrer changed the title fix: [#4545] Please upgrade zod package - botbuilder-dialogs fix: [#4545] Zod package - botbuilder-dialogs Nov 9, 2023
tracyboehrer pushed a commit that referenced this pull request Nov 13, 2023
* remove zod in botbuilder-dialogs

* update support for TS

* update botbuilder api signature

* update bf-schema api signature

* set zod versions

* remove skip

* fix lint

---------

Co-authored-by: JhontSouth <[email protected]>
# Conflicts:
#	libraries/botframework-schema/etc/botframework-schema.api.md
#	testing/consumer-test/run.ts
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgate zod package

3 participants