Skip to content

bump: Update babel related dependencies #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tracyboehrer merged 2 commits into from
Oct 31, 2023
Merged

bump: Update babel related dependencies #4556

tracyboehrer merged 2 commits into from
Oct 31, 2023

Conversation

@sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Oct 31, 2023

#minor

Description

This PR updates the majority of babel dependencies to the latest version due to the CVE-2023-45133 vulnerability issue with the @babel/traverse package.

Specific Changes

  • Updated @babel/* dependencies from current version 7.x.x to 7.23.2.
  • Added @babel/core dependency to resolutions due to being used by deprecated libraries.

Testing

The following image shows the echo bot working and the tests passing.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 31, 2023 13:28
@tracyboehrer
Copy link
Member

tracyboehrer commented Oct 31, 2023

@sw-joelmut Node 16 test fail:

  1. CloudAdapter
    process
    throws exception on expired token:
    Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/botbuilder-js/botbuilder-js/libraries/botbuilder/tests/cloudAdapter.test.js)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

@coveralls
Copy link

coveralls commented Oct 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6707218758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.802%
Totals Coverage Status
Change from base Build 6672490541: 0.0%
Covered Lines: 20269
Relevant Lines: 22645
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 0032ed7 into main Oct 31, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/babel branch October 31, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sw-joelmut @tracyboehrer @coveralls