fix: [#4440][Bot node.js] Compile error for accessing "conversation" and "organizer" fields for get meeting details bot API #4442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8333618617Details
💛 - Coveralls |
tracyboehrer
approved these changes
Mar 18, 2024
Member
|
@ceciliaavila This does change the signatures so the test-compat fails |
Collaborator
Author
Yes, I'm fixing the check now. Note: Although this would be a breaking change, as the method's signature was updated, the data returned by the method remained the same. Anyone using the old interface wouldn't be able to access its properties. |
This was referenced Jul 18, 2024
This was referenced Jul 28, 2024
This was referenced Sep 7, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4440
Description
This PR fixes the compile error in TS when trying to access the properties returned by the getMeetingInfo function.
It replaces the TeamsMeetingInfo return type with the correct MeetingInfo type, also matching with the .NET implementation.
Note: Although this would be a breaking change, as the method's signature was updated, the data returned by the method remained the same. Anyone using the old interface wouldn't be able to access its properties.
Specific Changes
Testing
These images show the compile error solved and the meeting info properly returned by the method.
