This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Bug fix for smoke test failures when PR is not found#6
Merged
samiyaakhtar merged 3 commits intomicrosoft:masterfrom Apr 14, 2020
Merged
Bug fix for smoke test failures when PR is not found#6samiyaakhtar merged 3 commits intomicrosoft:masterfrom
samiyaakhtar merged 3 commits intomicrosoft:masterfrom
Conversation
samiyaakhtar
requested review from
AdamTrukawka,
dennisseah,
edaena and
mtarng
and removed request for
AdamTrukawka
dennisseah
approved these changes
Apr 14, 2020
edaena
approved these changes
Apr 14, 2020
mtarng
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample smoke test: https://dev.azure.com/epicstuff/hellobedrock/_build/results?buildId=18903&view=results
This was happening only in some AzDO environments where multiple spk generated pipelines existed, so we've to handle the case when an array is returned.
Closes microsoft/bedrock#1330