This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Conversation
mtarng
approved these changes
May 5, 2020
mtarng
changed the title
Contributor
|
Looks good, this should be verified against the smoke tests we have that uses both the flag for a packages directory and has a file path for the service. We should follow up this ticket with the suggestion to deprecate and remove the flag for the packages directory for creating new services. |
andrebriggs
requested review from
NathanielRose,
andrebriggs,
dennisseah and
jmspring
jmspring
approved these changes
May 5, 2020
andrebriggs
reviewed
May 5, 2020
Member
edaena
changed the title
dennisseah
reviewed
May 5, 2020
dennisseah
reviewed
May 6, 2020
samiyaakhtar
approved these changes
May 6, 2020
Contributor
Author
|
Follow-up task to deprecate the packages flag: microsoft/bedrock#1416 |
edaena
changed the title
dennisseah
reviewed
May 6, 2020
| if (servicePath === "") { | ||
| throw buildError(errorStatusCode.VALIDATION_ERR, { | ||
| errorKey: "project-pipeline-err-service-missing", | ||
| values: [serviceName], |
Collaborator
There was a problem hiding this comment.
Do we have unit test for this?
Contributor
Author
There was a problem hiding this comment.
No, I'll make the update in a different pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves microsoft/bedrock/issues/1405