This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Merged
Conversation
andrebriggs
requested review from
dennisseah,
evanlouie,
jmspring,
mtarng,
samiyaakhtar and
yradsmikham
Member
Author
|
As expected the build failed due to code coverage. I will override, re-run, and set back once we merge the PR |
evanlouie
approved these changes
Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed references to
spkin most places and replaced with permutations ofbedrockandbedrock cliwhere applicable.Closes microsoft/bedrock#1354
Closes microsoft/bedrock#1361
Related to microsoft/bedrock#1384
skipin as covered here: Some CLI infra generate unit tests are not unit tests bedrock#1385