This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Caching design doc update#25
Merged
samiyaakhtar merged 10 commits intomicrosoft:masterfrom Apr 27, 2020
Merged
Conversation
evanlouie
reviewed
Apr 24, 2020
| How to change the refresh duration | ||
| How to change the refresh duration: Check the deployment environment variables | ||
| passed in through the docker image or helm chart, and add a variable | ||
| `REACT_APP_CACHE_REFRESH_IN_SEC` set it to let's say `60` for a 60 seconds |
Contributor
There was a problem hiding this comment.
Once this is added, this should also set the default refreshRate property in the frontend dashboard component state
Contributor
Author
There was a problem hiding this comment.
@evanlouie When the dashboard launches, should we apply this env setting by default to the refreshRate property in the component state?
Collaborator
There was a problem hiding this comment.
there are two refresh rate settings. One for backend and one for frontend. REACT_APP_CACHE_REFRESH_IN_SEC is for backend.
evanlouie
approved these changes
Apr 24, 2020
edaena
approved these changes
Apr 24, 2020
andrebriggs
previously requested changes
Apr 25, 2020
Member
andrebriggs
left a comment
andrebriggs
left a comment
There was a problem hiding this comment.
Pausing until other changes are complete
dennisseah
reviewed
Apr 27, 2020
| 3. Check if there are deleted deployed instances, if yes, remove them from the | ||
| cache. | ||
| 4. one API call to get Manifest Repo Sync State. | ||
| 4. Check if there are new or updated instances, and if yes, one API call to get |
dennisseah
approved these changes
Apr 27, 2020
Collaborator
dennisseah
left a comment
dennisseah
left a comment
There was a problem hiding this comment.
LGTM. This doc can be set to version 1.0 :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just updating the caching design doc with slight changes
Will make a draft PR against Spektate shortly, to start getting feedback for this implementation.
Related to microsoft/bedrock#1318