Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Guidance for Terraform + Bedrock Rollback#21

Merged
NathanielRose merged 21 commits intomicrosoft:masterfrom
NathanielRose:nate.docs.rollback
May 12, 2020
Merged

Guidance for Terraform + Bedrock Rollback#21
NathanielRose merged 21 commits intomicrosoft:masterfrom
NathanielRose:nate.docs.rollback

Conversation

@NathanielRose
Copy link
Contributor

Copy link

@nmiodice nmiodice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested to learn more about how this applies with a multi-environment deployment. The approach splits the rollback into a separate pipeline which makes the pipeline definition much simpler.

How will this work in a case where there are 2 environments. As an example, suppose I have dev and prod. What happens if I deploy to dev and end up needing a rollback. Will the original release pipeline know about that and block the deployment to prod?

Copy link
Member

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks like good guidance. I don't think this needs to be in a "design doc" format. This just seems like general documentation we can add to a guides/* section of the repo.

@NathanielRose were you thinking of doing the above, and/or adding guidance in the guides/* section of the repo? If so I see no reason to have this in technical-docs/designs

Copy link
Contributor

@samiyaakhtar samiyaakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to have a rollback guide, thanks Nate

@NathanielRose NathanielRose requested a review from edaena May 11, 2020 20:51
Copy link
Contributor

@mtarng mtarng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rewording, but looks good to me.

@NathanielRose NathanielRose merged commit 390b7b2 into microsoft:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guidance on rolling back with SPK Infra

8 participants