Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Updating MSI Docs#19

Merged
NathanielRose merged 8 commits intomicrosoft:masterfrom
NathanielRose:nate.docs.msi.chart
Apr 22, 2020
Merged

Updating MSI Docs#19
NathanielRose merged 8 commits intomicrosoft:masterfrom
NathanielRose:nate.docs.msi.chart

Conversation

@NathanielRose
Copy link
Contributor

Adding appendix

@NathanielRose NathanielRose marked this pull request as ready for review April 21, 2020 18:12
| Resolve Keys & Secrets | No | Yes |
| Staged Test Environment | Yes | Yes |
| Code Linting | Yes | Yes |
| Terraform Compliance | No | No |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does i t mean to be "Terraform Compliant"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Line 294

Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@NathanielRose NathanielRose merged commit c188261 into microsoft:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants