This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Passing arguments to a Dockerfile build process#16
Merged
yradsmikham merged 37 commits intomicrosoft:masterfrom Apr 20, 2020
Merged
Passing arguments to a Dockerfile build process#16yradsmikham merged 37 commits intomicrosoft:masterfrom
yradsmikham merged 37 commits intomicrosoft:masterfrom
Conversation
yradsmikham
requested review from
bnookala,
edaena,
evanlouie,
samiyaakhtar and
sarath-p
andrebriggs
previously requested changes
Apr 16, 2020
dennisseah
reviewed
Apr 16, 2020
mtarng
reviewed
Apr 16, 2020
Contributor
|
Let's definitely squash this when merging :| |
Contributor
Author
Yup, of course. |
samiyaakhtar
approved these changes
Apr 17, 2020
7 tasks
sarath-p
approved these changes
Apr 17, 2020
evanlouie
reviewed
Apr 17, 2020
evanlouie
reviewed
Apr 17, 2020
evanlouie
reviewed
Apr 17, 2020
evanlouie
approved these changes
Apr 17, 2020
andrebriggs
reviewed
Apr 17, 2020
dennisseah
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close microsoft/bedrock#1006.
Addresses Design Doc: https://github.com/microsoft/bedrock-cli/blob/master/technical-docs/designs/services/acrBuildArguments.md
Passed smoke tests: https://dev.azure.com/yvradsmi/spk-services/_build?definitionId=997&_a=summary