Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Plumb k8s version from environments to aks-gitops and aks modules#923

Merged
timfpark merged 18 commits intomicrosoft:masterfrom
timfpark:plumb_k8s_version
Feb 4, 2020
Merged

Plumb k8s version from environments to aks-gitops and aks modules#923
timfpark merged 18 commits intomicrosoft:masterfrom
timfpark:plumb_k8s_version

Conversation

@timfpark
Copy link
Contributor

@timfpark timfpark commented Jan 29, 2020

Adds kubernetes_version to each environment such that, as part of day 2 operations, you can do Kubernetes upgrades. In talking over #861 it was decided that explicitly specifying a version was better than using a script, as a script could potentially pull in a new default version for K8s in a way that is opaque for the operator.

Closes #861

@timfpark timfpark requested a review from jmspring January 29, 2020 18:12
Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


module "aks-gitops" {
source = "github.com/microsoft/bedrock?ref=master//cluster/azure/aks-gitops"
source = "../cluster/azure/aks-gitops"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this "../../azure/aks-gitops"

@timfpark timfpark merged commit 7f6387a into microsoft:master Feb 4, 2020
timfpark added a commit that referenced this pull request Feb 25, 2020
* Add git_label flux terraform variable (#820)

* Revert "Add git_label flux terraform variable (#820)" (#837)

This reverts commit 85731ae.

* Add git-label variable to terraform template for flux (#851)

* Fixes kube config output writing to console (#853)

* Fixes #802

* Added doc to redownload the credentials

* Reverting module sources

* Re-enabling Integration Test white listing for Bedrock (#865)

* trigger Azure-simple integration test

* testing new simple IT

* testing var syntax

* adding tasks

* adjusting dependencies

* new changes

* checking in export task

* validating

* stage dependency test

* removing stages

* adding job dependency

* syntax switch on env vars

* adding job toggling to al IT

* Whitelist_Bedrock.

* merging stages to repair issue with pipeline vars

* syntax repair

* syntax

* Publishing artifacts for future repair

* removing debug prints

* removing comments

* Reference deploy azure cluster section (#876)

Doc changes, no need to wait for build.

* [DOC] Fix typo, state helm version and sample git repo name (#879)

* Reference deploy azure cluster section

* [DOC] Fix typo, reference link and helm version

* allow single service principal, some deprecation clean up (#911)

* allow single service principal, some deprecation clean up

* add check for same sp (#930)

* add check for same sp

* Plumb k8s version from environments to aks-gitops and aks modules (#923)

* Remove flex volume

* Plumb Kubernetes version down to aks-gitops and aks with AKS default as the default

* temporarily point to my branch

* push default up to environment

* Revert to using master to prepare for PR

* Add kubernetes_version to other environments

* Fix test to include Kubernetes version

* Add Kubernetes version to tests

* Fix MC test

* Fix Simple test

* Fix KV Test

* Fix Single Cosmos Test

* Use branch path for now for azure-simple

* Use branch local paths for now

* Use relative paths for tests

* Fix aks-gitops url in azure-simple

* Revert to master URLs

* Deprecation.cleanup (#950)

* fix deprecations

* Fix type to Terraform 0.12 format (#957)

* Fix helm init (#962)

Make it client only

* Nate.scheduled.builds (#1014)

* trigger Azure-simple integration test

* testing new simple IT

* testing var syntax

* adding tasks

* adjusting dependencies

* new changes

* checking in export task

* validating

* stage dependency test

* removing stages

* adding job dependency

* syntax switch on env vars

* adding job toggling to al IT

* Whitelist_Bedrock.

* merging stages to repair issue with pipeline vars

* syntax repair

* syntax

* Publishing artifacts for future repair

* removing debug prints

* removing comments

* Adding scheduled pipelines

* adjusting paths for template pipelines

* testing with comments

* Refactor README into progressive levels of complexity

Co-authored-by: Edaena Salinas <[email protected]>
Co-authored-by: Sarath Pinninty <[email protected]>
Co-authored-by: Nate <[email protected]>
Co-authored-by: Dennis Seah <[email protected]>
Co-authored-by: Jim Spring <[email protected]>
Co-authored-by: Bhargav Nookala <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace hard coded AKS Kubernetes version with a script to check current default version.

2 participants