Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

[WIP] Adjusting modules to relative paths#1189

Merged
NathanielRose merged 3 commits intomasterfrom
nate.infra.relative.paths
Apr 29, 2020
Merged

[WIP] Adjusting modules to relative paths#1189
NathanielRose merged 3 commits intomasterfrom
nate.infra.relative.paths

Conversation

@NathanielRose
Copy link
Contributor

@NathanielRose NathanielRose commented Mar 17, 2020

@jmspring
Copy link
Contributor

Please test with SPK. Per an issue @timfpark encountered, SPK does not pull down related modules, just the target environment and terraform init will fail.

Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test with SPK

@NathanielRose NathanielRose changed the title Adjusting modules to relative paths [WIP] Adjusting modules to relative paths Mar 18, 2020
@NathanielRose
Copy link
Contributor Author

NathanielRose commented Mar 18, 2020

Please test with SPK

SPK validation is Blocked until #1194 is completed

@andrebriggs
Copy link
Member

@NathanielRose Looks good. Please ping when this works with the CLI and ir out of draft state

@NathanielRose NathanielRose marked this pull request as ready for review April 22, 2020 17:43
@NathanielRose NathanielRose requested a review from jmspring April 22, 2020 18:15
Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NathanielRose NathanielRose merged commit fb46fbe into master Apr 29, 2020
@NathanielRose NathanielRose deleted the nate.infra.relative.paths branch May 18, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure common infra modules should use relative paths

5 participants