Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

spk install pipeline log messages are inaccurate and validation for pipeline definition file is incorrect #1188

@mtarng

Description

@mtarng

Describe the bug:
Screen Shot 2020-03-17 at 12 27 52 PM
The above log only reflects that the PAT given is valid for the AzDo org, we could combine this log to reflect that.

Additionally:

mitarng@mtarng:~/Workspace/spk/tests/spk-env/fabrikam2019$ spk project install-lifecycle-pipeline --org-name mitarng --devops-project feb18project --repo-url https://dev.azure.com/mitarng/
feb18project/_git/doesnotexist --pipeline-name lifecycle-pipeline2
info:    Attempting to authenticate with Azure DevOps organization 'mitarng' using PAT '************************************************lh6q'
info:    Successfully connected to Azure DevOps Git API!
info:    Fetched DevOps Client
info:    Attempting to create new pipeline: lifecycle-pipeline2 defined in repository:https://dev.azure.com/mitarng/feb18project/_git/doesnotexist, branch: master, filePath: hld-lifecycle.
yaml
info:    Creating pipeline for definition
info:    Created pipeline for lifecycle-pipeline2
info:    Pipeline ID: 197

in the above example https://dev.azure.com/mitarng/feb18project/_git/doesnotexist does not exist, but somehow spk is still attempting to create the pipeline.

Expected behavior:
Input validations should work correctly.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions