Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Issue in spk reconcile setting k8sSvcBackendAndName #1175

@andrebriggs

Description

@andrebriggs

Describe the bug:
The common.yaml file produced by the spk-reconcile process is missing the service name. The image below shows the result of a pull request produced by the lifecycle pipeline.
image

The code here seems to be the issue. We should check for empty values before we concatenate most likely.

I suspect this might be an issue with the fact that the bedrock.yaml only contains a displayName and an empty k8sBackend:

rings:
  master:
    isDefault: true
services:
  ./:
    displayName: quick-start-app
    helm:
      chart:
        accessTokenVariable: ACCESS_TOKEN_SECRET
        branch: master
        git: 'https://dev.azure.com/abrig/BedrockRocks/_git/quick-start-helm'
        path: quick-start-app/chart
    k8sBackend: ''
    k8sBackendPort: 0
    middlewares: []
    pathPrefix: ''
    pathPrefixMajorVersion: ''
variableGroups:
  - quick-start-vg

To Reproduce:

Expected behavior:
I should have a valid service name in common.yaml

Screenshots:

Additional context:

Does this require updates to documentation?:

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions