chore(BeachballOptions): Move scope to RepoOptions type#599
Merged
Conversation
The `scope` CLI option, can be used in the configuration file regardless of it being a cli specific option. Adds `scope` to the `RepoOptions` type so that it can be used in the config file as a part of `BeachballConfig` Also improves the options types by making `CliOptions` extend shared `RepoOptions`.
2 tasks
ecraig12345
reviewed
Sep 20, 2021
| export type BeachballOptions = CliOptions & RepoOptions & PackageOptions; | ||
|
|
||
| export interface CliOptions { | ||
| export interface CliOptions |
Member
There was a problem hiding this comment.
I like the alphabetizing but it makes diffing challenging--were any properties removed from here?
Contributor
Author
There was a problem hiding this comment.
No removals, apart from alphebetizing, the only change was to add scope to RepoOptions
ecraig12345
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scopeCLI option, can be used in the configuration file regardlessof it being a cli specific option.
Adds
scopeto theRepoOptionstype so that it can be used in theconfig file as a part of
BeachballConfigAlso improves the options types by making
CliOptionsextend sharedRepoOptions. Also sorts the options for easier readability in the future.