Repository navigation
feat(azurelinux-logos): add azurelinux-logo.ico + fedora-logo.ico symlink - #18073
Merged
Merged
Conversation
…link wsl-setup defaults its distribution icon to /usr/share/pixmaps/fedora-logo.ico (ICON_PATH in the wsl-setup script) and pulls it in via `Requires: system-logos`, which azurelinux-logos provides. Until now the package shipped only PNG/SVG fedora-logo compat variants, so that path was missing. Ship the Windows ICO asset as /usr/share/pixmaps/azurelinux-logo.ico and add a fedora-logo.ico compat symlink pointing at it, matching the existing fedora-logo.png/.svg compatibility pattern. Signed-off-by: Muhammad Falak R Wani <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the ICO compatibility asset required by wsl-setup.
Changes:
- Packages
azurelinux-logo.ico. - Adds the
fedora-logo.icocompatibility symlink. - Refreshes rendered spec metadata and component lock fingerprint.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
base/comps/azurelinux-logos/azurelinux-logos.spec |
Defines, installs, and packages the ICO asset and symlink. |
specs/a/azurelinux-logos/azurelinux-logos.spec |
Updates the rendered RPM specification. |
locks/azurelinux-logos.lock |
Refreshes the component input fingerprint. |
Contributor
|
How did you test this fix? Did you build and verify the file exists when you build from your commit? Can you also please verify the symlink works as expected? |
Member
Author
I built the package locally and tested it:
|
Member
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
reuben olinsky (reubeno)
approved these changes
Jul 21, 2026
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsl-setup defaults its distribution icon to /usr/share/pixmaps/fedora-logo.ico
(ICON_PATH in the wsl-setup script) and pulls it in via
Requires: system-logos,which azurelinux-logos provides. Until now the package shipped only PNG/SVG
fedora-logo compat variants, so that path was missing.
Ship the Windows ICO asset as /usr/share/pixmaps/azurelinux-logo.ico and add a
fedora-logo.ico compat symlink pointing at it, matching the existing
fedora-logo.png/.svg compatibility pattern.
Signed-off-by: Muhammad Falak R Wani [email protected]