Skip to content

Include support for MSBuild version 18 #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanjays-ms merged 10 commits into from
Nov 26, 2025
Merged

Include support for MSBuild version 18 #510

sanjays-ms merged 10 commits into from
Nov 26, 2025

Conversation

@sanjays-ms
Copy link
Contributor

@sanjays-ms sanjays-ms commented Nov 17, 2025 •
edited
Loading

Description

AB#2335263
microsoft/azure-pipelines-tasks#21319

Related Task PR: microsoft/azure-pipelines-tasks#21476

Package Name

msbuildhelpers, packagingcommon (nuget)

Risk Assessment (Low / Medium / High)

Low_

Unit Tests Added or Updated

  • Unit tests added or updated
  • Manual tests performed

Additional Testing Performed

Tested through self hosted image with new Visual studio and msbuild installed internal pipeline
Microsoft hosted images don't have latest versions of MSBuild yet

Documentation Changes Required (Yes / No)

Indicate whether related documentation needs to be updated. Provide links to the updated documentation if applicable.

Dependencies

List any dependencies introduced or updated in this PR.

Checklist

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 17, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 17, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 17, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms sanjays-ms marked this pull request as ready for review November 18, 2025 10:16
@sanjays-ms sanjays-ms requested review from a team and tarunramsinghani as code owners November 18, 2025 10:16
@ToreDemant
Copy link

ToreDemant commented Nov 19, 2025

What about the NuGetToolGetter.ts - that seems to need changes too:
https://github.com/microsoft/azure-pipelines-tasks-common-packages/pull/506/files#diff-9172623af284a064a00dde0009d7ff5c88aa6930b7c4a24c391127058b2410dc

@andysterland andysterland mentioned this pull request Nov 19, 2025
Closed
4 tasks
@ToreDemant
Copy link

ToreDemant commented Nov 19, 2025

What about the NuGetToolGetter.ts - that seems to need changes too: https://github.com/microsoft/azure-pipelines-tasks-common-packages/pull/506/files#diff-9172623af284a064a00dde0009d7ff5c88aa6930b7c4a24c391127058b2410dc

@andysterland this one is missing compared to your proposed changes - do you recon it is needed here too?

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 20, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 20, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ToreDemant
Copy link

ToreDemant commented Nov 20, 2025

@sanjays-ms what about the Visual Studio handling in NuGetToolGetter.ts:
https://github.com/microsoft/azure-pipelines-tasks-common-packages/blob/main/common-npm-packages/packaging-common/nuget/NuGetToolGetter.ts#L154

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 20, 2025

@sanjays-ms what about the Visual Studio handling in NuGetToolGetter.ts: https://github.com/microsoft/azure-pipelines-tasks-common-packages/blob/main/common-npm-packages/packaging-common/nuget/NuGetToolGetter.ts#L154

This PR focuses solely on the MSBuild task, and the file NuGetToolGetter.ts is not a dependency for this task.
Updates for other tasks, such as VSBuild, Nuget, or Dotnet, will be addressed in upcoming PRs.
If it's necessary to update that file for other tasks, those changes will be included in upcoming PRs.

@ToreDemant
Copy link

ToreDemant commented Nov 20, 2025

@sanjays-ms The title of this PR is Include support for MSBuild version 18 and the function in NuGetToolGetter.ts is called getMSBuildVersionString - it sounds somewhat connected.

It also seems to be the only remaining msbuild fix in azure-pipelines-tasks-common-packages, which is why I am trying to get in included, so there does not have to be one more change for the same done later.

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 20, 2025

@sanjays-ms The title of this PR is Include support for MSBuild version 18 and the function in NuGetToolGetter.ts is called getMSBuildVersionString - it sounds somewhat connected.

It also seems to be the only remaining msbuild fix in azure-pipelines-tasks-common-packages, which is why I am trying to get in included, so there does not have to be one more change for the same done later.

Sure, will check needed changes to Nuget related tasks as well and add it to this same PR
Thank you for the feedback
Apologies about the title initial intention was to create PRs task wise and initially this PR was for MSBuildV1 task only but will check all related changes to other tasks as well and make needed changes for new version of MSBuild.

@sanjays-ms sanjays-ms requested a review from a team as a code owner November 21, 2025 07:39
@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms sanjays-ms mentioned this pull request Nov 21, 2025
Merged
3 tasks
@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 25, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@sanjays-ms
Copy link
Contributor Author

sanjays-ms commented Nov 25, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ToreDemant ToreDemant mentioned this pull request Nov 25, 2025
Open
2 tasks
@sanjays-ms sanjays-ms merged commit 6587531 into main Nov 26, 2025
9 checks passed
@sanjays-ms sanjays-ms deleted the users/v-sanjayse/WI2335263-update-msbuildhelpers branch November 26, 2025 04:54
@sanjays-ms sanjays-ms mentioned this pull request Nov 27, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarunramsinghani tarunramsinghani tarunramsinghani approved these changes

@jmyersmsft jmyersmsft jmyersmsft approved these changes

@AlexVTor AlexVTor Awaiting requested review from AlexVTor

+1 more reviewer

@ToreDemant ToreDemant ToreDemant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sanjays-ms @ToreDemant @tarunramsinghani @jmyersmsft