Adding support for VS2026 #506
Conversation
Added 18 as a valid version, which it is for VS2026 though it's currently prerelease so won't show up unless the call to `vswhere` includes the `-prerelease` argument.
|
Should this fallback solution also be extended with 2026? |
Good catch, thanks. I've updated the file. For VS2026 the file path is /18/ rather than 2026. Still using the Enterprise SKU and the stable/release channel in the fallback. Not sure if it's important but the fallback could be updated to check the other two SKUs (Pro and Community), an issue for a later day. |
andysterland
requested review from
a team and
tarunramsinghani
as code owners
|
@jmyersmsft could you re-review the changes? The PR needed a merge from main before it can merge. Thanks! |
|
@andysterland / @jmyersmsft / @tarunramsinghani can something be done to get this PR through? |
|
This is being worked upon in https://github.com/microsoft/azure-pipelines-tasks-common-packages/pull/510/files. Will close this in favor of above PR. Thanks. |
|
Thank you for the quick reply @tarunramsinghani Glad that is is being worked on! |
|
Closing this as it's superseded by #510 |
4 participants
Description
Adding 18 to the valid set of VS version numbers. No new tests were added, consistent with the change to add 17. In general it looks like the tasks relies on distinguishing being between versions of VS < 16 or later, with the logic for >= 16 versions being the same - and the behavior for 18.0 is the same
Issue
Package Name
msbuildhelpers
Risk Assessment (Low / Medium / High)
Low
Unit Tests Added or Updated
Additional Testing Performed
Documentation Changes Required (Yes / No)
No
Dependencies
None
Checklist