fix(docs): make back-to-top button keyboard accessible#7246
Open
dhawalc wants to merge 1 commit into
Open
Conversation
- Add tabindex='0' to make button focusable - Add aria-label for screen readers - Add keydown handler for Enter/Space activation - Announce scroll action via live region Fixes issue microsoft#25 in microsoft#6090
Author
|
Agreed and approved |
Author
|
@microsoft-github-policy-service agree [company="dhawal Chheda"] |
Author
|
@microsoft-github-policy-service agree @microsoft-github-policy-service agree company=Accel4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the back-to-top button keyboard accessible, addressing issue #25 from #6090.
Changes
tabindex='0'to make the button focusable via keyboard navigationaria-label='Back to top'for screen readersrole='button'for proper semanticsTesting
Related Issues
Partially fixes #6090 (issue 25: Back to Top control is not accessible with keyboard)