fix: enable function_calling for o1-2024-12-17#6725
Merged
Conversation
o1-2024-12-17 model has function_calling feature
withsmilo
reviewed
Jun 27, 2025
ekzhu
approved these changes
Jun 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6725 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 232 232
Lines 17403 17403
=======================================
Hits 13878 13878
Misses 3525 3525
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
_model_info.pyincorrectly marked o1-2024-12-17 as not supporting function calling.This blocks Autogen’s function-calling agent and produces runtime errors.
The model actually supports the feature, so the flag is flipped to
True.What does this PR do?
"function_calling": Trueforo1-2024-12-17.Related issue
n/a (internal hot-fix)
Checks
pre-commit run --all-filesand all hooks passed.tests/test_model_info.py::test_function_calling_flag).