Fix header icons focus and hover style for better accessibility#6409
Merged
Conversation
peterychang
reviewed
May 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 225 225
Lines 16549 16549
=======================================
Hits 13001 13001
Misses 3548 3548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterychang
approved these changes
May 9, 2025
16 tasks
peterj
added a commit
to peterj/autogen
that referenced
this pull request
May 10, 2025
…j/fix6481 * 'peterj/fix6481' of github.com:peterj/autogen: improve Otel tracing (microsoft#6499) Fix header icons focus and hover style for better accessibility (microsoft#6409)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR improves keyboard accessibility by ensuring that header links/icons have visual feedback (underline and color change) on both hover and keyboard focus states. Also adds smooth scaling animation.
Related issue number
Related issue: #6090
Checks