Refactor GPTAssistantAgent #632
Merged
Merged
Conversation
instructions and overwrite_instructions flag - Ensure that `system_message` is always consistent with `instructions` - Ensure provided instructions are always used - Add option to permanently modify the instructions of the assistant
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
===========================================
+ Coverage 28.90% 51.64% +22.73%
===========================================
Files 27 27
Lines 3359 3377 +18
Branches 757 801 +44
===========================================
+ Hits 971 1744 +773
+ Misses 2317 1439 -878
- Partials 71 194 +123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sonichi
reviewed
Nov 11, 2023
qingyun-wu
reviewed
Nov 11, 2023
qingyun-wu
approved these changes
Nov 11, 2023
qingyun-wu
left a comment
qingyun-wu
left a comment
Contributor
There was a problem hiding this comment.
Should add tests as Chi suggested. Otherewise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Refactor constructor to handle
instructionsandoverwrite_instructionsflagsystem_messageis always consistent withinstructionsrun)Related issue number
Checks