Added a LangChain tooling bridge example by ElliotWood · Pull Request #58 · microsoft/autogen

ElliotWood · 2023-10-01T04:04:09Z

Why are these changes needed?

As per discord feedback it was clear the LangChain integrations would be beneficial to this project. This example shows how to give your AutoGen agent the callability to use a LangChain toolkit/tool to solve the problem or query.

This means we can inherit the 35+ integrations from the LangChain community, but using the agent power of AutoGen.

Checks

I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
I've added tests (if relevant) corresponding to the changes introduced in this PR. (Not relevant)
I've made sure all auto checks have passed.

ElliotWood · 2023-10-01T04:05:57Z

@microsoft-github-policy-service agree company="LAB3"

AaronWard · 2023-10-01T14:36:20Z

Great work @ElliotWood - this will be super useful, would be cool to have this ability in something like integration_utils.py

gagb

Great PR!

Feedback:

clarify the path of Test.txt. In my run, I had to place in cwd even when work_dir is set to coding. (Mac with python 3.11)
Spark example requires setting up key differently from circumference example. It would be great if the reader has to set everything in the beginning once.

pcdeadeasy

Great example to bring in LangChain tools and agents into Autogen.

gagb · 2023-10-02T19:32:58Z

@ElliotWood, lmk if the feedback makes sense before I can approve it to be added to the repo.

wgong · 2023-10-04T03:54:50Z

@ElliotWood Great PR, can you share a high-level perspective on AutoGen vs LangChain: how they overlap and differ? Thanks.

wgong · 2023-10-04T04:04:46Z

@ElliotWood posted the question to Bard, here is the answer, which is pretty good

ElliotWood · 2023-10-05T09:14:53Z

@ElliotWood, lmk if the feedback makes sense before I can approve it to be added to the repo.

Hey just an FYI, im on vacation till the 20th I will push the updated feedback once ive returned, unless someone else wants to do it earlier ;)

sonichi · 2023-10-12T04:51:07Z

@gagb can your comments be addressed in a separate PR or must be fixed in this PR? If the former, we can merge this PR and create an issue.

thinkall

+1 for adding this into a utils file, but this can be done in another PR.

gagb · 2023-10-14T20:18:27Z

@gagb can your comments be addressed in a separate PR or must be fixed in this PR? If the former, we can merge this PR and create an issue.

The pr works just needs more documentation clarity if you want a new user to be able to run it. I am okay your suggestion..

remove key

codecov-commenter · 2023-10-14T21:46:14Z

Codecov Report

Merging #58 (59d9622) into main (ea8dec7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   43.31%   43.31%           
=======================================
  Files          17       17           
  Lines        2133     2133           
  Branches      481      481           
=======================================
  Hits          924      924           
  Misses       1126     1126           
  Partials       83       83

Flag	Coverage Δ
unittests	`43.22% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

ElliotWood · 2023-10-15T13:21:46Z

Just found this from Langchain side
https://python.langchain.com/docs/modules/agents/tools/tools_as_openai_functions
Could provide similar functionality

sonichi · 2023-10-15T15:07:41Z

@gagb can your comments be addressed in a separate PR or must be fixed in this PR? If the former, we can merge this PR and create an issue.

The pr works just needs more documentation clarity if you want a new user to be able to run it. I am okay your suggestion..

Would you like to create an issue after this PR is merged?

sonichi · 2023-10-16T03:21:12Z

The merging is blocked by "push cannot contain secrets" even though I've removed the keys in the PR. @ElliotWood do you think creating a new PR without secrets is the right solution?

AaronWard · 2023-10-16T09:56:25Z

@sonichi https://docs.github.com/en/enterprise-cloud@latest/code-security/secret-scanning/push-protection-for-repositories-and-organizations#bypassing-push-protection-for-a-secret

gagb · 2023-10-16T17:23:59Z

@gagb can your comments be addressed in a separate PR or must be fixed in this PR? If the former, we can merge this PR and create an issue.

The pr works just needs more documentation clarity if you want a new user to be able to run it. I am okay your suggestion..

Would you like to create an issue after this PR is merged?

Yes, should I wait for merge or create now?

ElliotWood · 2023-10-16T23:28:47Z

The merging is blocked by "push cannot contain secrets" even though I've removed the keys in the PR. @ElliotWood do you think creating a new PR without secrets is the right solution?

Will do mate, I'm on vacation until the 20th so I don't have my laptop I will need to do it when i get back, apologies

sonichi · 2023-10-16T23:30:17Z

@gagb can your comments be addressed in a separate PR or must be fixed in this PR? If the former, we can merge this PR and create an issue.

The pr works just needs more documentation clarity if you want a new user to be able to run it. I am okay your suggestion..

Would you like to create an issue after this PR is merged?

Yes, should I wait for merge or create now?

create after #263 is merged. And this PR will be closed.

…ter presentation. (#58) * Improve assistant and chess examples to make them more robust and better presentation. * type dep * format

Added a LangChain tooling bridge example

6855276

Updated Doco

f9aa0d0

sonichi requested review from a team, ekzhu and pcdeadeasy October 1, 2023 14:21

gagb requested changes Oct 1, 2023

View reviewed changes

pcdeadeasy approved these changes Oct 2, 2023

View reviewed changes

thinkall reviewed Oct 12, 2023

View reviewed changes

Comment thread notebook/agentchat_langchain.ipynb Outdated

gagb approved these changes Oct 14, 2023

View reviewed changes

Update agentchat_langchain.ipynb

d4fd387

remove key

sonichi enabled auto-merge October 14, 2023 21:42

Merge branch 'main' into lancgain_tool_bridge

7d37179

Merge branch 'main' into lancgain_tool_bridge

59d9622

sonichi mentioned this pull request Oct 16, 2023

Langchain tool bridge (#262) #263

Merged

3 tasks

sonichi closed this in #263 Oct 16, 2023

auto-merge was automatically disabled October 16, 2023 23:32
Pull request was closed

jackgerrits pushed a commit that referenced this pull request Oct 2, 2024

Improve assistant and chess examples to make them more robust and bet…

37cc6bc

…ter presentation. (#58) * Improve assistant and chess examples to make them more robust and better presentation. * type dep * format

Conversation

ElliotWood commented Oct 1, 2023

Why are these changes needed?

Checks

Uh oh!

ElliotWood commented Oct 1, 2023

Uh oh!

AaronWard commented Oct 1, 2023

Uh oh!

gagb left a comment

Choose a reason for hiding this comment

Uh oh!

pcdeadeasy left a comment

Choose a reason for hiding this comment

Uh oh!

gagb commented Oct 2, 2023

Uh oh!

wgong commented Oct 4, 2023

Uh oh!

wgong commented Oct 4, 2023

Uh oh!

ElliotWood commented Oct 5, 2023

Uh oh!

sonichi commented Oct 12, 2023

Uh oh!

thinkall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gagb commented Oct 14, 2023

Uh oh!

codecov-commenter commented Oct 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ElliotWood commented Oct 15, 2023

Uh oh!

sonichi commented Oct 15, 2023

Uh oh!

sonichi commented Oct 16, 2023

Uh oh!

AaronWard commented Oct 16, 2023

Uh oh!

gagb commented Oct 16, 2023

Uh oh!

ElliotWood commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonichi commented Oct 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov-commenter commented Oct 14, 2023 •

edited

Loading

ElliotWood commented Oct 16, 2023 •

edited

Loading