Skip to content

Commit af07e33

Browse files
eerhardtmitchdennyCopilot
authored
[release/13.6] Pin MessagePack to 2.5.307 for security fixes (#21156)
Backport of #21051 to release/13.6 ## Customer Impact NuGet reports NU1902 (vulnerable MessagePack 2.5.302, pulled in transitively by StreamJsonRpc) and fails restores/builds that treat warnings as errors. Pinning to MessagePack 2.5.307 picks up the patched 2.x releases. ## Testing Validated on main per #21051: repo restore with `-warnaserror -p:NuGetAudit=true` (0 warnings/errors), CLI backchannel tests passed (29), Hosting pack nuspec requires MessagePack 2.5.307. Not separately re-run on release/13.6. Conflict in Directory.Packages.props (previous 2.5.302 pin) resolved by taking 2.5.307. ## Risk Low. Dependency patch bump within MessagePack 2.x; StreamJsonRpc unchanged. ## Regression? No. Co-authored-by: Mitch Denny <[email protected]> Co-authored-by: Copilot App <[email protected]> Copilot-Session: 25f67c97-c7d9-43c6-be44-a406e0bf1b17
1 parent 3f42c5c commit af07e33

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎Directory.Packages.props‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,9 @@
125125
<PackageVersion Include="Humanizer.Core" Version="3.0.10" />
126126
<PackageVersion Include="KubernetesClient" Version="19.0.2" />
127127
<PackageVersion Include="Markdig" Version="1.3.2" />
128-
<!-- Pin StreamJsonRpc's transitive dependency without replacing the CLI's NativeAOT preview.
129-
2.5.302 combines the security fixes in 2.5.205 and 2.5.301:
130-
https://github.com/MessagePack-CSharp/MessagePack-CSharp/releases/tag/v2.5.302 -->
131-
<PackageVersion Include="MessagePack" Version="2.5.302" />
128+
<!-- Pin StreamJsonRpc's transitive dependency for 2.x security fixes until it adopts MessagePack 3.x.
129+
Remove this pin when upgrading StreamJsonRpc: https://github.com/microsoft/aspire/issues/21050 -->
130+
<PackageVersion Include="MessagePack" Version="2.5.307" />
132131
<!-- 2.0.1's transitive runtime targets set RuntimeIdentifier after restore, breaking
133132
RID-independent library and AppHost builds with NETSDK1047. Retain 1.1.0 until fixed upstream. -->
134133
<PackageVersion Include="Microsoft.AI.Foundry.Local" Version="1.1.0" />

‎src/Aspire.Hosting/Aspire.Hosting.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@
8383
The public AspireTerminal handle keeps these implementation types out of the API surface. -->
8484
<PackageReference Include="Hex1b" />
8585
<PackageReference Include="KubernetesClient" />
86+
<!-- Central transitive pins do not flow to out-of-tree ProjectReference consumers.
87+
Keep this explicit security pin until https://github.com/microsoft/aspire/issues/21050 is resolved. -->
88+
<PackageReference Include="MessagePack" />
8689
<PackageReference Include="Microsoft.Extensions.Hosting" />
8790
<PackageReference Include="ModelContextProtocol" />
8891
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" />

0 commit comments

Comments
 (0)