fix: replace non-ASCII characters with ASCII equivalents

chkp-roniz · claude · chkp-roniz · commit 1680050d46f3 · 2026-03-31T05:32:30.000+03:00
Replace U+2192 (-&gt;), U+2014 (--), U+2013 (--), U+2026 (...),
and box-drawing chars with printable ASCII to comply with the
project's cp1252-safe encoding policy.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,10 +10,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- `RegistryConfig` dataclass in `apm_cli.deps.registry_proxy` — registry-agnostic abstraction over VCS proxies; reads canonical `PROXY_REGISTRY_URL` / `PROXY_REGISTRY_TOKEN` / `PROXY_REGISTRY_ONLY` env vars with deprecated fallback to `ARTIFACTORY_*` aliases
-- `InstalledPackage` dataclass in `apm_cli.deps.installed_package` — replaces the ad hoc positional tuple used to accumulate install results before lockfile generation; `LockFile.from_installed_packages()` accepts both the new dataclass and legacy tuples
-- `LockedDependency.registry_prefix` field in `apm.lock.yaml` — stores the URL path prefix (e.g. `artifactory/github`) separately from the pure FQDN `host`; enables correct auth token routing and air-gapped re-installs through the same proxy
-- `PROXY_REGISTRY_ONLY` / `PROXY_REGISTRY_URL` / `PROXY_REGISTRY_TOKEN` — canonical generic registry env vars replacing the deprecated `ARTIFACTORY_*` equivalents (deprecated aliases still work with a `DeprecationWarning`)
+- `RegistryConfig` dataclass in `apm_cli.deps.registry_proxy` -- registry-agnostic abstraction over VCS proxies; reads canonical `PROXY_REGISTRY_URL` / `PROXY_REGISTRY_TOKEN` / `PROXY_REGISTRY_ONLY` env vars with deprecated fallback to `ARTIFACTORY_*` aliases
+- `InstalledPackage` dataclass in `apm_cli.deps.installed_package` -- replaces the ad hoc positional tuple used to accumulate install results before lockfile generation; `LockFile.from_installed_packages()` accepts both the new dataclass and legacy tuples
+- `LockedDependency.registry_prefix` field in `apm.lock.yaml` -- stores the URL path prefix (e.g. `artifactory/github`) separately from the pure FQDN `host`; enables correct auth token routing and air-gapped re-installs through the same proxy
+- `PROXY_REGISTRY_ONLY` / `PROXY_REGISTRY_URL` / `PROXY_REGISTRY_TOKEN` -- canonical generic registry env vars replacing the deprecated `ARTIFACTORY_*` equivalents (deprecated aliases still work with a `DeprecationWarning`)
 - Post-download `content_hash` verification: fresh downloads are now verified against the lockfile's recorded SHA-256 hash; a mismatch aborts the install with a supply-chain warning instead of silently accepting different content
 - `RegistryConfig.find_missing_hashes()` warns at startup when registry-proxy lockfile entries lack a `content_hash`, prompting `--update` to populate them for tamper detection
 
diff --git a/docs/src/content/docs/getting-started/authentication.md b/docs/src/content/docs/getting-started/authentication.md
@@ -165,12 +165,12 @@ Air-gapped environments route all VCS traffic through a JFrog Artifactory proxy.
 |----------|---------|
 | `PROXY_REGISTRY_URL` | Full proxy base URL, e.g. `https://art.example.com/artifactory/github` |
 | `PROXY_REGISTRY_TOKEN` | Bearer token for the proxy |
-| `PROXY_REGISTRY_ONLY` | Set to `1` to block all direct VCS access — only proxy downloads allowed |
+| `PROXY_REGISTRY_ONLY` | Set to `1` to block all direct VCS access -- only proxy downloads allowed |
 
 ```bash
 export PROXY_REGISTRY_URL=https://art.example.com/artifactory/github
 export PROXY_REGISTRY_TOKEN=your_bearer_token
-export PROXY_REGISTRY_ONLY=1    # optional — enforces proxy-only mode
+export PROXY_REGISTRY_ONLY=1    # optional -- enforces proxy-only mode
 
 apm install
 ```
@@ -184,7 +184,7 @@ After a successful proxy install, `apm.lock.yaml` records the proxy host and pat
 ```yaml
 dependencies:
   - repo_url: owner/repo
-    host: art.example.com        # pure FQDN — no path
+    host: art.example.com        # pure FQDN -- no path
     registry_prefix: artifactory/github  # path prefix
     resolved_commit: abc123def456
 ```
diff --git a/src/apm_cli/deps/installed_package.py b/src/apm_cli/deps/installed_package.py
@@ -33,7 +33,7 @@ class InstalledPackage:
         The exact commit SHA that was installed, or ``None`` for local / Artifactory
         packages where no commit is available.
     depth:
-        Dependency tree depth (1 = direct, 2 = transitive, …).
+        Dependency tree depth (1 = direct, 2 = transitive, ...).
     resolved_by:
         ``repo_url`` of the parent that introduced this dependency, or ``None``
         for direct dependencies.
diff --git a/src/apm_cli/deps/registry_proxy.py b/src/apm_cli/deps/registry_proxy.py
@@ -6,17 +6,17 @@
 
 Environment variables (canonical)::
 
-    PROXY_REGISTRY_URL      – Full proxy base URL, e.g.
+    PROXY_REGISTRY_URL      -- Full proxy base URL, e.g.
                             ``https://art.example.com/artifactory/github``
-    PROXY_REGISTRY_TOKEN    – Bearer token for the proxy.
-    PROXY_REGISTRY_ONLY     – Set to ``1``/``true``/``yes`` to block all
+    PROXY_REGISTRY_TOKEN    -- Bearer token for the proxy.
+    PROXY_REGISTRY_ONLY     -- Set to ``1``/``true``/``yes`` to block all
                             direct VCS downloads.
 
 Deprecated aliases (still functional, emit ``DeprecationWarning``)::
 
-    ARTIFACTORY_BASE_URL  → PROXY_REGISTRY_URL
-    ARTIFACTORY_APM_TOKEN → PROXY_REGISTRY_TOKEN
-    ARTIFACTORY_ONLY      → PROXY_REGISTRY_ONLY
+    ARTIFACTORY_BASE_URL  -> PROXY_REGISTRY_URL
+    ARTIFACTORY_APM_TOKEN -> PROXY_REGISTRY_TOKEN
+    ARTIFACTORY_ONLY      -> PROXY_REGISTRY_ONLY
 """
 
 from __future__ import annotations
@@ -60,7 +60,7 @@ class RegistryConfig:
     token:
         Optional Bearer token for authenticating against the proxy.
     enforce_only:
-        When ``True``, direct VCS downloads are blocked — only the proxy
+        When ``True``, direct VCS downloads are blocked -- only the proxy
         may serve packages.
     """
 
@@ -194,7 +194,7 @@ def is_enforce_only() -> bool:
 
     Checks ``PROXY_REGISTRY_ONLY`` first; falls back to the deprecated
     ``ARTIFACTORY_ONLY``.  Does **not** require a full :class:`RegistryConfig`
-    to be available — callers that only need the flag (e.g.
+    to be available -- callers that only need the flag (e.g.
     :class:`~apm_cli.deps.github_downloader.GitHubPackageDownloader`) can
     use this without constructing the full config.
     """
diff --git a/tests/unit/test_artifactory_support.py b/tests/unit/test_artifactory_support.py
@@ -851,7 +851,7 @@ def test_proxy_registry_only_raises_same_as_artifactory_only(self):
                 dl.download_package("microsoft/some-package", Path("/tmp/test-pkg"))
 
 
-# ── RegistryConfig: FQDN / prefix split and generic registry ──
+# -- RegistryConfig: FQDN / prefix split and generic registry --
 
 
 class TestRegistryConfig:
@@ -926,7 +926,7 @@ def test_deprecated_artifactory_base_url_alias(self):
         assert any(issubclass(warning.category, DeprecationWarning) for warning in w)
 
     def test_registry_config_lockfile_round_trip(self):
-        """host and registry_prefix survive YAML write → read round trip."""
+        """host and registry_prefix survive YAML write -> read round trip."""
         from apm_cli.deps.lockfile import LockedDependency, LockFile
         from apm_cli.deps.registry_proxy import RegistryConfig
 
@@ -951,7 +951,7 @@ def test_registry_config_lockfile_round_trip(self):
         assert dep2.registry_prefix == "artifactory/github"
 
 
-# ── drift.py: build_download_ref with registry_prefix ──
+# -- drift.py: build_download_ref with registry_prefix --
 
 
 class TestBuildDownloadRefRegistryPrefix:
@@ -1036,14 +1036,14 @@ def test_update_refs_bypasses_lockfile_host(self):
         assert ref is dep  # --update returns original dep_ref unchanged
 
 
-# ── RegistryConfig.validate_lockfile_deps: conflict detection ──
+# -- RegistryConfig.validate_lockfile_deps: conflict detection --
 
 
 class TestRegistryOnlyConflictDetection:
     """Test validate_lockfile_deps uses classify_host for accurate conflict detection."""
 
     def test_github_com_dep_is_a_conflict(self):
-        """github.com host is a direct VCS source → conflict when enforce_only=True."""
+        """github.com host is a direct VCS source -> conflict when enforce_only=True."""
         from apm_cli.deps.lockfile import LockedDependency, LockFile
         from apm_cli.deps.registry_proxy import RegistryConfig
 
@@ -1123,7 +1123,7 @@ def test_enforce_only_false_returns_no_conflicts(self):
         assert cfg.validate_lockfile_deps([locked]) == []
 
 
-# ── RegistryConfig.find_missing_hashes: supply chain integrity ──
+# -- RegistryConfig.find_missing_hashes: supply chain integrity --
 
 
 class TestFindMissingHashes:
