Repository navigation
fix(agent-sre): preserve alert fingerprint field boundaries - #4208
MohammadHaroonAbuomar merged 2 commits into
Conversation
Signed-off-by: Naveen Chatlapalli <[email protected]>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
|
Verified in code and locally: Before I approve, two process items that apply to all nine PRs in this batch: please use the repository template with its Checklist, Attribution, AI Assistance and IP sections, and tick the attestations in your own words. The AI note says Codex prepared and submitted the changes at your request; CONTRIBUTING asks that no PR be submitted by an agent without a human reviewing the specific changes, so one sentence confirming you reviewed this diff before it was opened settles it. Once that and the gated checks are green I will approve and merge. |
|
I reviewed the specific changes in this diff before the PR was opened. I have updated the description to use the repository template sections, completed the attestations with the validation scope and limitations, and clarified the AI-assistance note. Commit d443efd fixes the CI spelling failure for the existing alert class name. The changed-line spelling check and all 34 alert deduplication tests pass locally. |
Signed-off-by: Naveen Chatlapalli <[email protected]>
MohammadHaroonAbuomar
left a comment
There was a problem hiding this comment.
Approving at d443efd. Alert fingerprint joins fields with an unambiguous separator so adjacent fields cannot collide; new test fails on main and passes here; cspell term added for the test; ruff clean. Description uses the repository template with the attestations completed, and the author confirmed reviewing the diff before opening the PR. All 12 pull_request workflow runs on this head completed successfully. Commits are signed off.
Description
Distinct alerts can serialize to the same deduplication input. For example,
(agent_id='agent|title=worker', title='Breach')and(agent_id='agent', title='worker|title=Breach')both becomeagent_id=agent|title=worker|title=Breach; the second alert is incorrectly suppressed.Encode the field/value pairs as JSON before hashing. The regression exercises delivery of both alerts and continued suppression of actual duplicates. Fingerprint digests change; the built-in deduplication state is in memory, and no persisted-key migration is added.
Validation
The delivery regression fails before the fix. Alert and deduplication tests: 67 passed. Full package run: 1,495 passed, 3 skipped, 1 known baseline failure (the separate Windows benchmark clock bug).
All regressions were reproduced on origin/main
406ddd4dbefore the production change. Whitespace checks pass. Ruff passes on the changed files. Changed-line spelling passes with the allowance for the existing API identifier committed on the new test line.Scope: the existing Agent-SRE source tree, which remains exercised by repository CI. Combined validation of these six independent SRE fixes: 1,505 passed, 3 skipped on Windows/Python 3.12.
Commit d443efd adds a spelling allowance for the existing AlertDeduplicator identifier on the new test line. The changed-line artifact passes the CI-pinned cspell 8.17.3 with the repository configuration, and the alert deduplication test file passes again (34 tests).
Type of Change
Package(s) Affected
Checklist
Attribution & Prior Art
Prior art / related projects: Uses the existing Agent-SRE implementation and standard library operations. No code was copied or adapted from an external project.
AI Assistance
I reviewed the specific changes in this diff before this PR was opened.
Codex assisted with implementation, regression tests, and local validation under my direction.
IP, Patents, and Licensing
Related Issues
Newly reproduced defect; the reproduction and regression coverage are described above.