Repository navigation
Python: Harden FIDES replay and approval authority - #9876
Eduard van Valkenburg (eavanvalkenburg) merged 17 commits into
Conversation
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): 40521719e14d
Model: gpt-5.6-sol
Overview
The change adds conservative replay classification, exact session-owned placeholder authentication, and canonical approval bindings with strong mutation, depth, duplicate-key, and lifecycle guards. Exact control tokens and pending-session snapshots substantially reduce approval replay authority. However, local per-service history can bypass classification entirely, restored-history coverage is represented by an unbound session-wide boolean, and pre-upgrade hidden placeholders are rejected by the new canonical encoding.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
3 verified findings remained after source verification (2 high, 1 medium) across 2 files. Details are attached to the affected lines below.
Affected areas: python/packages/core/agent_framework/_agents.py, python/packages/core/agent_framework/security.py
4052171 to
85a6ad1
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
Hashingcontent.to_dict()makes approval-control authority extremely sensitive to… · New_ApprovalReplayAuthorityrelies on the module-global nameid(...). Because global name… · New_is_pending_approval_controllinearly scans everyscope.pending_approvalsitem for each… · New This post-provider hook is a good place to finalize history-based reconstruction, but in runs where… · New
What changed in this PR
Hardens FIDES handling of replayed/history-provided content and approval controls so that callers cannot regain trust/authority by replaying or forging IDs, and missing label state is reconstructed conservatively.
Changes:
- Add conservative replay label classification (including depth/cycle/duplicate-key defenses) and authenticated hidden-placeholder verification.
- Bind approval authority to canonical stored call bodies + exact live controls, and reconstruct history labels after history providers load.
- Extend agent session preparation to run provider-specific approval-history preparation; expand regression coverage and documentation.
| File | Description |
|---|---|
| python/packages/core/agent_framework/security.py | Implements replay classification, hidden-placeholder authentication, and approval replay authority binding. |
| python/packages/core/agent_framework/_agents.py | Invokes provider _prepare_approval_history hook after providers run to finalize reconstruction/binding. |
| python/packages/core/tests/test_security.py | Adds extensive regression tests for replay classification, placeholder integrity, and approval binding. |
| python/samples/02-agents/security/FIDES_DEVELOPER_GUIDE.md | Documents conservative replay behavior and approval authority rules. |
| docs/features/FIDES_IMPLEMENTATION_SUMMARY.md | Updates FIDES summary to include replay/history-provider behavior and trust boundary notes. |
Review effort: Lite
85a6ad1 to
f886ebe
Compare
f886ebe to
3d53a28
Compare
3d53a28 to
41602fd
Compare
cb21a86 to
d59f3de
Compare
d59f3de to
1367abd
Compare


Motivation & Context
FIDES security state must remain conservative when callers or history providers replay assistant, tool, function-result,
and approval content. Unstamped replay data, modified hidden placeholders, or caller-forged approval controls must not
inherit trust or execution authority from IDs alone.
Applications also need an explicit way to classify data added by their own context providers without adding
FIDES-specific stamping logic to those providers. This PR keeps that authority inside
SecureAgentConfigand preservesconservative behavior for data the application has not classified.
Description & Review Guide
conservatively, authenticates exact session-owned hidden placeholders, and binds FIDES and ordinary approvals to
canonical stored call bodies, exact live controls, and pending session snapshots.
SecureAgentConfigaccepts anoptional synchronous
message_labeler(source_id, message)callback. FIDES uses the authoritativeSessionContext.context_messagesbucket assource_id, applies the returnedContentLabelat fold points, caches itfor the exact message object during the run, and does not mutate or stamp provider messages.
SecureAgentConfigmust follow non-history providers whose messages it classifies; explicit history providers should also precede it
when they need application-owned labels. Ordinary history loaded later is reconstructed conservatively before tool
policy executes. Per-service-call history that is unavailable at run setup fails closed as
UNTRUSTED + PRIVATE.
approvals remain usable, and applications can classify their own provider data as trusted, untrusted, public,
private, or identity-scoped. The simplification removes the provider-authority class, two one-use middleware classes,
message stamping, and no-op replay middleware. It adds no
ContextProviderlifecycle API. The new parameter isoptional and experimental; this is not a breaking change.
authority and untrusted serialized labels, the use of authoritative provider buckets rather than message attribution,
exact-object authority through replay, and the private FIDES preflight for later-loaded ordinary history. Also verify
that core remains the execution authority for approvals and that this change does not expand the public
ContextProviderlifecycle. This layer intentionally excludes precise service-history continuation ownership,AG-UI replay provenance, and MCP result carrier behavior.
Related Issue
Fixes #9652
#9652 is the original source draft. This PR is its focused replay-and-approval-authority replacement. The policy,
state, and materialization foundation from #9875 is already present, while service-history continuation, AG-UI
provenance, and MCP carrier work remain in later replacement layers.
AI Assistance
AI assistance details: GitHub Copilot assisted with implementation, regression tests, documentation, and this PR
description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.