Repository navigation
.NET: Dotnet: Add approval reuse considerations - #9389
westey (westey-m) merged 3 commits into
Conversation
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Failure
github-actions
Bot
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
The documentation recommends clearing approval state without exposing or documenting a supported way to do so.
1 open finding
What changed in this PR
Adds security guidance for reusing standing tool approvals across agents and changing tool sets.
Changes:
- Documents session-scoped approval persistence.
- Warns about name collisions, particularly with MCP tools.
- Clarifies approval reuse decisions after agent or tool upgrades.
| File | Description |
|---|---|
ToolApprovalRequestContentExtensions.cs |
Adds reuse guidance to approval helpers. |
ToolApprovalAgentBuilderExtensions.cs |
Adds security guidance to middleware setup. |
ToolApprovalAgent.cs |
Documents risks and upgrade considerations. |
AlwaysApproveToolApprovalResponseContent.cs |
Documents standing-rule scope. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): a8fa25f1d7f6
Model: gpt-5.6-sol
Overview
This documentation-only change accurately warns that standing approvals are session-scoped and match tool names and arguments rather than stable tool identities. Existing request binding, exact-argument matching, replay protection, and auto-approval iteration limits constrain adjacent risks, while the underlying cross-tool identity risk remains pre-existing behavior that this PR explicitly documents. No PR-introduced Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Removed reference to clearing the standing approval state in remarks. Co-authored-by: Copilot Autofix powered by AI <[email protected]>
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
Motivation & Context
Improve documentation around what to consider when doing standing approvals with agent upgrades / multiple agents.
Description & Review Guide
Improve documentation around what to consider when doing standing approvals with agent upgrades / multiple agents.
Related Issue
Fixes #
AI Assistance
AI assistance details:
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.