Repository navigation
[BREAKING] Python: Move path normalization to common shared code - #8123
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 5 commits intoSep 8, 2026
Conversation
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:21 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
agent-framework-automation
Bot
added
documentation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The derivation still permits case-insensitive collisions and silently relocates several existing persisted layouts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Centralizes filesystem-safe storage-key derivation to improve isolation consistency across Python persistence providers.
Changes:
- Adds shared storage-key encoding and safety helpers.
- Migrates session, todo, memory, and file-memory path derivation.
- Adds collision, Unicode, traversal, and isolation tests plus documentation updates.
File summaries
| File | Description |
|---|---|
python/samples/02-agents/context_providers/file_memory_provider.py |
Documents opaque scopes and uses a flat example. |
python/packages/core/tests/workflow/test_agent_executor.py |
Removes redundant whitespace. |
python/packages/core/tests/core/test_sessions.py |
Tests session filename isolation and Unicode encoding. |
python/packages/core/tests/core/test_harness_todo.py |
Tests todo-store key derivation. |
python/packages/core/tests/core/test_harness_memory.py |
Tests memory-store key derivation. |
python/packages/core/tests/core/test_harness_file_memory.py |
Tests scope isolation and fail-closed behavior. |
python/packages/core/tests/core/test_filesystem.py |
Covers the shared derivation helper. |
python/packages/core/AGENTS.md |
Documents storage-key conventions. |
python/packages/core/agent_framework/_sessions.py |
Reuses shared filename derivation. |
python/packages/core/agent_framework/_harness/_todo.py |
Reuses shared todo path derivation. |
python/packages/core/agent_framework/_harness/_memory.py |
Reuses shared memory path derivation. |
python/packages/core/agent_framework/_harness/_file_memory.py |
Encodes scopes as single storage segments. |
python/packages/core/agent_framework/_harness/_file_access.py |
Clarifies path-normalizer limitations. |
python/packages/core/agent_framework/_filesystem.py |
Implements shared storage-key helpers. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 6
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): 6b746d4ffaea
Model: gpt-5.6-sol-fast
Overview
This PR centralizes opaque storage-key derivation and adds strong traversal, reserved-name, Unicode-normalization, and isolation coverage. The shared encoding separates identifiers that the previous path normalizer folded together, but several consumers adopt it without preserving their existing persisted layouts. As a result, existing memory, file-memory, session/history, and todo data can appear missing after an upgrade.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
4 verified findings remained after source verification (1 high, 3 medium) across 4 files. Details are attached to the affected lines below.
Affected areas: python/packages/core/agent_framework/_filesystem.py, python/packages/core/agent_framework/_harness/_file_memory.py, python/packages/core/agent_framework/_harness/_memory.py, python/packages/core/agent_framework/_harness/_todo.py
westey (westey-m)
changed the title
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
changed the title
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 13:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
agent-framework-automation
Bot
added
the
breaking change
westey (westey-m)
temporarily deployed
to
github-app-auth
September 7, 2026 16:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 8, 2026 09:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 8, 2026 09:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
github-app-auth
September 8, 2026 10:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 8, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Improve consistency
Description & Review Guide
Move path normalization to common shared code
Related Issue
Fixes #
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.