Skip to content

docs: adds missing guidance for public api analyzers updates - #8035

Merged
Vincent Biret (baywet) merged 3 commits into
mainfrom
docs/public-analyzers-troubleshooting
Sep 3, 2026
Merged

Vincent Biret (baywet) merged 3 commits into
mainfrom
docs/public-analyzers-troubleshooting

Conversation

@baywet

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The guidance incorrectly treats RS0017 as fixable through the RS0016 baseline-update workflow.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds troubleshooting guidance for .NET public API analyzer diagnostics.

Changes:

  • Documents analyzer code-fix usage.
  • Adds a targeted dotnet format command.
File summaries
File Description
CONTRIBUTING.md Adds public API baseline troubleshooting guidance.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The removal guidance conflicts with unshipped API handling and the existing promotion script.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread CONTRIBUTING.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The documented RS0017 code fix and command do not exist or resolve the diagnostic.

Review details

Suppressed comments (1)

CONTRIBUTING.md:124

  • RS0017 has CodeFix: False in the analyzer metadata, so neither a “corresponding code fix” nor dotnet format --diagnostics RS0017 can create the *REMOVED* entry. The command will leave contributors with the warning unresolved; document the required manual baseline edit instead.
- `RS0017` reports that a declared public API was deleted. Restore the API if the deletion was accidental; otherwise, record the removed signature in the package's `PublicAPI.Unshipped.txt` file with the `*REMOVED*` prefix by using the corresponding code fix, or the following dotnet format script:

  ```powershell
  dotnet format .\dotnet\agent-framework-dotnet.slnx analyzers --diagnostics RS0017

- **Files reviewed:** 1/1 changed files
- **Comments generated:** 0 new
- **Review effort level:** Balanced
</details>

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit e2633f8 Sep 3, 2026
26 checks passed
@baywet
Vincent Biret (baywet) deleted the docs/public-analyzers-troubleshooting branch September 17, 2026 14:29

This branch was previously deployed

1 inactive deployment
github-app-auth — 9d99593d Deployed Sep 3, 2026 by baywet via add_label #21842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants