Repository navigation
docs: adds missing guidance for public api analyzers updates - #8035
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The guidance incorrectly treats RS0017 as fixable through the RS0016 baseline-update workflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds troubleshooting guidance for .NET public API analyzer diagnostics.
Changes:
- Documents analyzer code-fix usage.
- Adds a targeted
dotnet formatcommand.
File summaries
| File | Description |
|---|---|
CONTRIBUTING.md |
Adds public API baseline troubleshooting guidance. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: baywet <[email protected]>
There was a problem hiding this comment.
🟡 Changes recommended
The removal guidance conflicts with unshipped API handling and the existing promotion script.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Signed-off-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
🔵 Needs a closer look
The documented RS0017 code fix and command do not exist or resolve the diagnostic.
Review details
Suppressed comments (1)
CONTRIBUTING.md:124
RS0017hasCodeFix: Falsein the analyzer metadata, so neither a “corresponding code fix” nordotnet format --diagnostics RS0017can create the*REMOVED*entry. The command will leave contributors with the warning unresolved; document the required manual baseline edit instead.
- `RS0017` reports that a declared public API was deleted. Restore the API if the deletion was accidental; otherwise, record the removed signature in the package's `PublicAPI.Unshipped.txt` file with the `*REMOVED*` prefix by using the corresponding code fix, or the following dotnet format script:
```powershell
dotnet format .\dotnet\agent-framework-dotnet.slnx analyzers --diagnostics RS0017
- **Files reviewed:** 1/1 changed files
- **Comments generated:** 0 new
- **Review effort level:** Balanced
</details>
No description provided.