Python: Fix OllamaChatClient passing unsupported kwargs to ollama.AsyncClient… - #4403

Pull request overview

Fixes the Ollama Python adapter to avoid forwarding orchestration/middleware-injected **kwargs into the Ollama SDK call (ollama.AsyncClient.chat()), preventing unexpected-keyword TypeErrors during workflows like handoffs.

Changes:

• Stop passing _inner_get_response() **kwargs through to ollama.AsyncClient.chat() (streaming and non-streaming paths).
• Add regression tests ensuring unsupported kwargs (e.g., allow_multiple_tool_calls) are not forwarded in either mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Automated Code Review

Reviewers: 3 | Confidence: 91%

✓ Correctness

The diff correctly fixes issue #4402 by stopping the forwarding of unsupported **kwargs to ollama.AsyncClient.chat() and adding allow_multiple_tool_calls to the set of keys excluded during option preparation. The three new tests cover the non-streaming kwargs path, the streaming kwargs path, and the options-dict path. The changes are focused, logically sound, and consistent with the existing codebase patterns.

✓ Security Reliability

This diff is a security improvement that removes the blind forwarding of **kwargs to the underlying Ollama AsyncClient.chat() call, preventing callers from injecting arbitrary, unvalidated parameters into the downstream API. The addition of 'allow_multiple_tool_calls' to exclude_keys and the accompanying regression tests are well-structured. No security or reliability issues are introduced by this change.

✓ Test Coverage

The diff removes forwarding of **kwargs to ollama.AsyncClient.chat() and adds allow_multiple_tool_calls to the exclude_keys set in _prepare_options. Three new tests cover the non-streaming kwargs path, streaming kwargs path, and options-dict path respectively. Coverage is solid for the specific regression case (issue #4402). Minor gaps: no test verifies that arbitrary/unknown kwargs (beyond allow_multiple_tool_calls) are also silently dropped, which would better document the broader behavioral change of removing **kwargs forwarding entirely. test_cmc_ignores_unsupported_options omits a result assertion but the intent is clear.

Suggestions

• Consider logging a debug-level warning when kwargs are silently dropped, so that users who accidentally pass an unsupported parameter get some feedback during development rather than silent no-op behavior.
• Consider logging a debug-level warning when kwargs are silently dropped so that callers can diagnose unexpected behaviour during development, rather than having parameters disappear without any signal.
• Consider adding a test that passes an arbitrary unknown kwarg (e.g., some_future_flag=True) to get_response and asserts it does not appear in the self.client.chat() call. This would document the broader behavioral change (all kwargs are now dropped, not just allow_multiple_tool_calls).
• In test_cmc_ignores_unsupported_options, consider adding assert result.text == "test" for consistency with the other two new tests, to confirm the response is still valid after filtering.

Automated review by moonbox3's agents

Reviewed and approved.