Repository navigation
Python: fail assert_score_at_least when evaluator filter matches no scores - #10180
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoNov 9, 2026
Conversation
Dhruv Shaswat (Dhruv-Sh-git)
temporarily deployed
to
github-app-auth
November 9, 2026 03:36 — with
GitHub Actions
Inactive
Dhruv Shaswat (Dhruv-Sh-git)
temporarily deployed
to
github-app-auth
November 9, 2026 03:36 — with
GitHub Actions
Inactive
Dhruv Shaswat (Dhruv-Sh-git)
temporarily deployed
to
github-app-auth
November 9, 2026 03:37 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Nov 9, 2026
Dhruv Shaswat (Dhruv-Sh-git)
deleted the
fix/issue-10166-assert-score-missing-evaluator
branch
November 9, 2026 12:52
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10166.
Motivation & Context
Previously,
assert_score_at_least()could silently pass when an evaluator filter didn't match any scores. This could happen because of a typo in the evaluator name or a missing evaluation check, making it appear that the score validation had succeeded even though nothing was actually checked.Changes Made
EvalResults.assert_score_at_least()to keep track of matched scores and evaluator names across evaluation items and sub-results.EvalNotPassedErrorwhen a specified evaluator doesn't match any scores.Validation
uv run pytest packages/core/tests/core/test_local_eval.py— 97 passed.uv run pytest packages/core/tests/core/test_evaluation.py— 91 passed.uv run poe syntax -P core— Passed.uv run poe pyright -P core— 0 errors.AI Assistance
AI assistance was used during issue investigation, implementation, and writing regression tests. All changes were reviewed and tested locally.