Repository navigation
Python: export the six orchestrations names the runtime already serves - #10170
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoNov 9, 2026
Conversation
Hyacinth-of-Security (lxcxjxhx)
temporarily deployed
to
github-app-auth
November 7, 2026 15:54 — with
GitHub Actions
Inactive
Hyacinth-of-Security (lxcxjxhx)
temporarily deployed
to
github-app-auth
November 7, 2026 15:54 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the stub update declaring six existing runtime exports for type checkers.
No open issues 🎉
What changed in this PR
Aligns the orchestrations type stub with the API already exposed by the runtime, allowing type checkers to recognize six previously undeclared exports.
Changes:
- Adds the six missing names to the stub’s import block and
__all__, preserving ASCII ordering. - Leaves runtime code and behavior unchanged.
| File | Description |
|---|---|
python/packages/core/agent_framework/orchestrations/__init__.pyi |
Declares six existing runtime exports in the type-checking surface. |
Review effort: Balanced
Closed
2 tasks done
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Nov 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
agent_framework/orchestrations/__init__.pyis a lazy re-export namespace: it serves the names in its_IMPORTSlist through__getattr__, and__init__.pyideclares the same surface to type checkers. The two lists disagree — six names exist at runtime but are absent from the stub:Consequence:
from agent_framework.orchestrations import BaseGroupChatOrchestratorworks when the extra is installed, but a type checker resolves the module through the.pyiand reports an unknown import symbol — so users who follow the orchestrations samples get a red squiggle on correct code, and anyone reading the stub concludes the API is smaller than it is.Description & Review Guide
__all__, in the same ASCII order the file already uses. Nothing else moves; the runtime module is untouched.__init__.pyis not touched), and the.pyigains only names thatagent_framework_orchestrationsalready exports._IMPORTSlist is the thing to trim instead — say which direction you want and I will send that.Evidence:
The other five are defined in
python/packages/orchestrations/agent_framework_orchestrations/:ruff checkon the touched file: clean.Related Issue
N/A - trivial change. One stub file, twelve added lines, no runtime code and no design decision; the alternative direction (trim
_IMPORTS) is raised above rather than chosen silently.AI Assistance
AI assistance details: the mismatch was found with a static check that compares each
__init__.pyi__all__against the sibling runtime_IMPORTS; the six definitions and the package-level export ofTerminationConditionwere then confirmed by hand with the greps above. The description was written from those results.Contribution Checklist
ruff checkpasses, and no runtime module changed.