Repository navigation
Python: drop a console script whose callable does not exist - #10169
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoNov 9, 2026
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
Hyacinth-of-Security (lxcxjxhx)
temporarily deployed
to
github-app-auth
November 7, 2026 15:02 — with
GitHub Actions
Inactive
Hyacinth-of-Security (lxcxjxhx)
temporarily deployed
to
github-app-auth
November 7, 2026 15:02 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change removing the broken lightning console-script registration.
No open issues 🎉
What changed in this PR
Removes the broken lightning console-script entry from the Python lab package because its target callable does not exist.
Changes:
- Stops generating a
lightningexecutable that fails on import. - Leaves
gaia_viewer, thelightningextra, and theAgentFrameworkTracerlibrary API unchanged.
| File | Description |
|---|---|
python/packages/lab/pyproject.toml |
Deletes the invalid agent_framework_lab_lightning:main console-script registration. |
Review effort: Balanced
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Nov 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
python/packages/lab/pyproject.tomldeclares two console scripts:The
lightningtarget does not exist.lightning/agent_framework_lab_lightning/__init__.pydefines one public name,AgentFrameworkTracer(__all__ = ["AgentFrameworkTracer"]), so installingagent-framework-lab[lightning]produces alightningexecutable that fails on import instead of running. The twomain()functions in the package live inlightning/samples/train_tau2_agent.pyandlightning/samples/train_math_agent.py; neither is importable asagent_framework_lab_lightning:main.The sibling entry is fine:
viewer_mainis defined ingaia/agent_framework_lab_gaia/and re-exported from its__init__.py(line 8, listed in__all__on line 25).Description & Review Guide
lightningconsole script. Nothing else moves — no import, no package, no__init__.pip install "agent-framework-lab[lightning]"no longer advertises a command that cannot start. Thelightningextra and theagent_framework_lab_lightningpackage itself are untouched; library users importAgentFrameworkTracerexactly as before.lightningCLI is planned. If it is, the fix should be a realmain()inagent_framework_lab_lightningrather than removing the entry — say so and I will implement it instead. A command that raisesImportErrorthe first time a user types it is the worse of the two states, which is why this PR takes the removal path.Evidence gathered before touching anything (run on the parent commit):
Related Issue
N/A - trivial change. One deleted line, no design decision, and the alternative (implementing the CLI) is called out above rather than silently chosen.
AI Assistance
AI assistance details: the console-script target was found with a static check that resolves
module:attrentries inpyproject.tomlagainst the modules' top-level bindings; the absence ofmain, the sibling script's validity, and the lack of any workflow or docs reference were then confirmed by hand with the commands above. The description was written from those results.Contribution Checklist
tomllib.load) and the resulting[project.scripts]is{'gaia_viewer': ...}.