|
| 1 | +# Copyright (c) Microsoft. All rights reserved. |
| 2 | + |
| 3 | +# ruff:file-ignore[implicit-namespace-package, undocumented-public-class, undocumented-public-method] |
| 4 | + |
| 5 | +from __future__ import annotations |
| 6 | + |
| 7 | +import sys |
| 8 | +import tempfile |
| 9 | +import unittest |
| 10 | +from pathlib import Path |
| 11 | + |
| 12 | +sys.path.insert(0, str(Path(__file__).parents[1] / "scripts")) |
| 13 | + |
| 14 | +from validate_agent_skill_links import validate_agent_skill_links |
| 15 | + |
| 16 | + |
| 17 | +class ValidateAgentSkillLinksTests(unittest.TestCase): |
| 18 | + def setUp(self) -> None: |
| 19 | + self.temp_dir = tempfile.TemporaryDirectory() |
| 20 | + self.root = Path(self.temp_dir.name) |
| 21 | + self.skills = self.root / "skills" |
| 22 | + self.skill = self.skills / "example-skill" |
| 23 | + self.skill.mkdir(parents=True) |
| 24 | + |
| 25 | + def tearDown(self) -> None: |
| 26 | + self.temp_dir.cleanup() |
| 27 | + |
| 28 | + def write_skill(self, body: str) -> None: |
| 29 | + (self.skill / "SKILL.md").write_text(body, encoding="utf-8") |
| 30 | + |
| 31 | + def test_accepts_regular_file_inside_skill(self) -> None: |
| 32 | + (self.skill / "references").mkdir() |
| 33 | + (self.skill / "references" / "details.md").write_text("# Details\n", encoding="utf-8") |
| 34 | + self.write_skill("[Details](references/details.md)\n") |
| 35 | + |
| 36 | + self.assertEqual([], validate_agent_skill_links(self.skills)) |
| 37 | + |
| 38 | + def test_accepts_reference_style_file_inside_skill(self) -> None: |
| 39 | + (self.skill / "references").mkdir() |
| 40 | + (self.skill / "references" / "details.md").write_text("# Details\n", encoding="utf-8") |
| 41 | + self.write_skill("[Details][resource]\n\n[resource]: references/details.md\n") |
| 42 | + |
| 43 | + self.assertEqual([], validate_agent_skill_links(self.skills)) |
| 44 | + |
| 45 | + def test_accepts_remote_links_mailto_and_anchors(self) -> None: |
| 46 | + self.write_skill( |
| 47 | + "[HTTP](http://example.com)\n" |
| 48 | + "[HTTPS][secure]\n" |
| 49 | + "[Email](mailto:[email protected])\n" |
| 50 | + "[Section](#section)\n" |
| 51 | + "\n" |
| 52 | + "[secure]: https://example.com\n" |
| 53 | + ) |
| 54 | + |
| 55 | + self.assertEqual([], validate_agent_skill_links(self.skills)) |
| 56 | + |
| 57 | + def test_rejects_parent_traversal(self) -> None: |
| 58 | + (self.skills / "outside.md").write_text("# Outside\n", encoding="utf-8") |
| 59 | + self.write_skill("[Outside](../outside.md)\n") |
| 60 | + |
| 61 | + errors = validate_agent_skill_links(self.skills) |
| 62 | + |
| 63 | + self.assertTrue(any("escapes skill root" in error for error in errors)) |
| 64 | + |
| 65 | + def test_rejects_reference_style_parent_traversal(self) -> None: |
| 66 | + (self.skills / "outside.md").write_text("# Outside\n", encoding="utf-8") |
| 67 | + self.write_skill("[Outside][resource]\n\n[resource]: ../outside.md\n") |
| 68 | + |
| 69 | + errors = validate_agent_skill_links(self.skills) |
| 70 | + |
| 71 | + self.assertTrue(any("escapes skill root" in error for error in errors)) |
| 72 | + |
| 73 | + def test_rejects_absolute_path(self) -> None: |
| 74 | + absolute_file = self.root / "outside.md" |
| 75 | + absolute_file.write_text("# Outside\n", encoding="utf-8") |
| 76 | + self.write_skill(f"[Outside]({absolute_file})\n") |
| 77 | + |
| 78 | + errors = validate_agent_skill_links(self.skills) |
| 79 | + |
| 80 | + self.assertTrue(any("absolute local link" in error for error in errors)) |
| 81 | + |
| 82 | + def test_rejects_directory_target(self) -> None: |
| 83 | + (self.skill / "references").mkdir() |
| 84 | + self.write_skill("[References](references)\n") |
| 85 | + |
| 86 | + errors = validate_agent_skill_links(self.skills) |
| 87 | + |
| 88 | + self.assertTrue(any("not a regular file" in error for error in errors)) |
| 89 | + |
| 90 | + def test_rejects_symlink_target(self) -> None: |
| 91 | + target = self.skill / "details.md" |
| 92 | + target.write_text("# Details\n", encoding="utf-8") |
| 93 | + (self.skill / "linked.md").symlink_to(target) |
| 94 | + self.write_skill("[Details](linked.md)\n") |
| 95 | + |
| 96 | + errors = validate_agent_skill_links(self.skills) |
| 97 | + |
| 98 | + self.assertTrue(any("not a regular file" in error for error in errors)) |
| 99 | + |
| 100 | + def test_rejects_file_uri(self) -> None: |
| 101 | + self.write_skill("[Outside](file:///tmp/outside.md)\n") |
| 102 | + |
| 103 | + errors = validate_agent_skill_links(self.skills) |
| 104 | + |
| 105 | + self.assertTrue(any("unsupported URI scheme" in error for error in errors)) |
| 106 | + |
| 107 | + def test_rejects_unknown_uri_scheme(self) -> None: |
| 108 | + self.write_skill("[Outside](custom://example/resource)\n") |
| 109 | + |
| 110 | + errors = validate_agent_skill_links(self.skills) |
| 111 | + |
| 112 | + self.assertTrue(any("unsupported URI scheme" in error for error in errors)) |
| 113 | + |
| 114 | + def test_rejects_missing_target(self) -> None: |
| 115 | + self.write_skill("[Missing](references/missing.md)\n") |
| 116 | + |
| 117 | + errors = validate_agent_skill_links(self.skills) |
| 118 | + |
| 119 | + self.assertTrue(any("missing local resource" in error for error in errors)) |
| 120 | + |
| 121 | + |
| 122 | +if __name__ == "__main__": |
| 123 | + unittest.main() |
0 commit comments