Skip to content

Commit 8213cc6

Browse files
fix(python): respect Foundry hosting history ownership
1 parent 5b4281f commit 8213cc6

2 files changed

Lines changed: 44 additions & 17 deletions

File tree

‎python/packages/foundry_hosting/agent_framework_foundry_hosting/_responses.py‎

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -563,18 +563,21 @@ def __init__(
563563
# Let the base host resolve its hosted/local default and validate any
564564
# explicitly supplied store before wrapping the resolved provider.
565565
self._failed_sync_response_ids: set[str] = set()
566-
orchestrator = self._orchestrator
567-
if orchestrator is None:
568-
raise RuntimeError("Responses host did not initialize its orchestrator.")
569-
history_store = orchestrator._provider
570-
wrapped_history_store = _OmitFailedConversationInputProvider(
571-
history_store,
572-
self._failed_sync_response_ids,
573-
)
574-
wrapped_provider = cast(ResponseProviderProtocol, wrapped_history_store)
575-
orchestrator._provider = wrapped_provider
576-
orchestrator._resilient_orchestrator._provider = wrapped_provider
577-
self._endpoint._provider = wrapped_provider # pyright: ignore[reportPrivateUsage]
566+
if uses_agent_server_history and not is_workflow_agent:
567+
# Agent-owned history does not replay this transcript. Preserve its
568+
# protocol-level response storage without filtering failed inputs.
569+
orchestrator = self._orchestrator
570+
if orchestrator is None:
571+
raise RuntimeError("Responses host did not initialize its orchestrator.")
572+
history_store = orchestrator._provider
573+
wrapped_history_store = _OmitFailedConversationInputProvider(
574+
history_store,
575+
self._failed_sync_response_ids,
576+
)
577+
wrapped_provider = cast(ResponseProviderProtocol, wrapped_history_store)
578+
orchestrator._provider = wrapped_provider
579+
orchestrator._resilient_orchestrator._provider = wrapped_provider
580+
self._endpoint._provider = wrapped_provider # pyright: ignore[reportPrivateUsage]
578581

579582
self._uses_agent_server_history = uses_agent_server_history
580583
self._client_stores_by_default = client_stores_by_default
@@ -664,7 +667,12 @@ async def _handle_response(
664667
) -> AsyncIterable[ResponseStreamEvent | ResponseCheckpointEvent]:
665668
"""Handle the creation of a response."""
666669
events = self._handle_response_events(request, context, cancellation_signal)
667-
if not self._is_workflow_agent and request.get("stream") is not True and request.get("background") is not True:
670+
if (
671+
self._uses_agent_server_history
672+
and not self._is_workflow_agent
673+
and request.get("stream") is not True
674+
and request.get("background") is not True
675+
):
668676
events = self._buffer_sync_response_events(
669677
events,
670678
context.response_id,

‎python/packages/foundry_hosting/tests/test_responses.py‎

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,7 +1296,10 @@ def failing_run(*_args: Any, **kwargs: Any) -> ResponseStream[AgentResponseUpdat
12961296
assert stored is not None
12971297
assert stored.state["before_failure"] == "saved"
12981298

1299-
async def test_failed_conversation_input_is_not_in_subsequent_history(self) -> None:
1299+
@pytest.mark.parametrize("history_source", ["agent_server", "agent"])
1300+
async def test_failed_conversation_input_is_not_in_subsequent_history(
1301+
self, history_source: Literal["agent_server", "agent"]
1302+
) -> None:
13001303
"""Failed conversation input must not be replayed on the next turn.
13011304
13021305
The agentserver store, not the MAF session, is what #7630 poisons:
@@ -1319,7 +1322,7 @@ def run_dispatch(*args: Any, **kwargs: Any) -> ResponseStream[AgentResponseUpdat
13191322

13201323
agent.run = MagicMock(side_effect=run_dispatch)
13211324
response_store = InMemoryResponseProvider()
1322-
server = _make_server(agent, response_store=response_store)
1325+
server = _make_server(agent, response_store=response_store, history_source=history_source)
13231326

13241327
failed = await _post_json(
13251328
server,
@@ -1361,7 +1364,23 @@ def run_dispatch(*args: Any, **kwargs: Any) -> ResponseStream[AgentResponseUpdat
13611364
history_ids = await response_store.get_history_item_ids(None, "conv-failed", 100)
13621365
history_items = await response_store.get_items(history_ids)
13631366
history_blob = json.dumps(history_items)
1364-
assert "call_12345abc" not in history_blob
1367+
if history_source == "agent_server":
1368+
assert "call_12345abc" not in history_blob
1369+
else:
1370+
# AgentServer still retains the protocol transcript in agent-history
1371+
# mode, but hosting does not replay it into the model.
1372+
assert "call_12345abc" in history_blob
1373+
1374+
async def test_agent_history_does_not_buffer_or_wrap_response_storage(self) -> None:
1375+
agent = _make_agent(response=AgentResponse(messages=[Message("assistant", ["done"])]))
1376+
response_store = InMemoryResponseProvider()
1377+
server = _make_server(agent, response_store=response_store, history_source="agent")
1378+
1379+
assert server._endpoint._provider is response_store # pyright: ignore[reportPrivateUsage]
1380+
with patch.object(server, "_buffer_sync_response_events", side_effect=AssertionError("must not buffer")):
1381+
response = await _post(server, input_text="first", stream=False)
1382+
1383+
assert response.json()["status"] == "completed"
13651384

13661385
async def test_omit_failed_conversation_input_provider_drops_terminal_failed_input(self) -> None:
13671386
inner = InMemoryResponseProvider()
@@ -1479,7 +1498,7 @@ def test_explicit_volatile_store_still_fails_resilient_background_guard(self) ->
14791498
options = ResponsesServerOptions(resilient_background=True)
14801499

14811500
with pytest.raises(ValueError, match="resilient_background=True"):
1482-
ResponsesHostServer(_make_agent(), store=InMemoryResponseProvider(), options=options)
1501+
ResponsesHostServer(_build_text_workflow_agent("done"), store=InMemoryResponseProvider(), options=options)
14831502

14841503
async def test_run_save_failure_emits_failed_response(self) -> None:
14851504
store = _FailingSessionStore()

0 commit comments

Comments
 (0)