Repository navigation
Commit 652c3d0
committed
Address review: classify 403 as auth, wrap non-APIError failures, cover mid-stream errors
- Map HTTP 403 (Anthropic PermissionDeniedError / Gemini ClientError) to
ChatClientInvalidAuthException, matching Mistral's 401/403 handling.
- Replace the provider-specific except chain with a catch-all that routes
every non-framework exception through a _wrap_*_error helper, so transport
failures and credential-refresh errors no longer escape ChatClientException.
- Re-raise AgentFrameworkException (e.g. ContentError) untouched.
- Extend tests to cover 403, a non-APIError fallback, and a failure raised
partway through iterating the stream (generator yields then raises).1 parent 8e129fd commit 652c3d0
4 files changed
Lines changed: 119 additions & 75 deletions
File tree
- python/packages
- anthropic
- agent_framework_anthropic
- tests
- gemini
- agent_framework_gemini
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
95 | 97 | | |
96 | 98 | | |
97 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
98 | 117 | | |
99 | 118 | | |
100 | 119 | | |
| |||
566 | 585 | | |
567 | 586 | | |
568 | 587 | | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
579 | 592 | | |
580 | 593 | | |
581 | 594 | | |
| |||
584 | 597 | | |
585 | 598 | | |
586 | 599 | | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | | - | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
595 | 604 | | |
596 | 605 | | |
597 | 606 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 34 | | |
38 | 35 | | |
39 | 36 | | |
| |||
43 | 40 | | |
44 | 41 | | |
45 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
1817 | 1818 | | |
1818 | 1819 | | |
1819 | 1820 | | |
1820 | | - | |
| 1821 | + | |
1821 | 1822 | | |
1822 | | - | |
1823 | | - | |
1824 | | - | |
1825 | | - | |
1826 | | - | |
1827 | | - | |
1828 | | - | |
1829 | | - | |
1830 | | - | |
1831 | | - | |
1832 | | - | |
1833 | | - | |
1834 | | - | |
1835 | | - | |
1836 | | - | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
1837 | 1830 | | |
1838 | 1831 | | |
1839 | 1832 | | |
1840 | 1833 | | |
1841 | | - | |
1842 | | - | |
| 1834 | + | |
1843 | 1835 | | |
1844 | 1836 | | |
1845 | 1837 | | |
1846 | 1838 | | |
1847 | 1839 | | |
1848 | 1840 | | |
1849 | | - | |
| 1841 | + | |
1850 | 1842 | | |
1851 | 1843 | | |
1852 | 1844 | | |
| |||
1858 | 1850 | | |
1859 | 1851 | | |
1860 | 1852 | | |
1861 | | - | |
1862 | | - | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
1863 | 1856 | | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
1864 | 1861 | | |
1865 | 1862 | | |
1866 | 1863 | | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
1867 | 1869 | | |
1868 | | - | |
1869 | | - | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
1870 | 1876 | | |
| 1877 | + | |
| 1878 | + | |
1871 | 1879 | | |
1872 | 1880 | | |
1873 | 1881 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | | - | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
80 | 98 | | |
81 | 99 | | |
82 | 100 | | |
| |||
572 | 590 | | |
573 | 591 | | |
574 | 592 | | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
583 | 597 | | |
584 | 598 | | |
585 | 599 | | |
586 | 600 | | |
587 | 601 | | |
588 | 602 | | |
589 | 603 | | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
590 | 608 | | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | | - | |
595 | | - | |
596 | | - | |
597 | | - | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
604 | 614 | | |
605 | 615 | | |
606 | 616 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | 20 | | |
23 | 21 | | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
387 | 388 | | |
388 | 389 | | |
389 | 390 | | |
| 391 | + | |
390 | 392 | | |
391 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
392 | 397 | | |
393 | 398 | | |
394 | 399 | | |
395 | | - | |
| 400 | + | |
396 | 401 | | |
397 | 402 | | |
398 | 403 | | |
| |||
406 | 411 | | |
407 | 412 | | |
408 | 413 | | |
409 | | - | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
410 | 417 | | |
411 | 418 | | |
412 | 419 | | |
413 | 420 | | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
414 | 426 | | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
419 | 434 | | |
420 | | - | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
421 | 438 | | |
422 | 439 | | |
423 | 440 | | |
| |||
0 commit comments