Skip to content

Commit 60d9e33

Browse files
Python: preserve date/time serialization contexts
Keep date and time conversion scoped to dictionary values while retaining recursive protocol and container serialization.
1 parent 869fd03 commit 60d9e33

2 files changed

Lines changed: 15 additions & 11 deletions

File tree

‎python/packages/core/agent_framework/_serialization.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,6 @@ def _serialize_value(
162162
"""Recursively serialize a value while preserving skip semantics."""
163163
if type(value) in _JSON_SCALAR_TYPES:
164164
return value
165-
if isinstance(value, (datetime, date, time)):
166-
return str(value)
167165
if _is_serialization_protocol(value):
168166
serialized = value.to_dict(exclude=exclude, exclude_none=exclude_none)
169167
return _serialize_value(
@@ -187,6 +185,9 @@ def _serialize_value(
187185
if isinstance(value, dict):
188186
serialized_dict: dict[str, Any] = {}
189187
for raw_key, item in cast(dict[Any, Any], value).items():
188+
if isinstance(item, (datetime, date, time)):
189+
serialized_dict[str(raw_key)] = str(item)
190+
continue
190191
serialized = _serialize_value(
191192
item,
192193
exclude=exclude,

‎python/packages/core/tests/core/test_serializable_mixin.py‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import json
66
import logging
7+
from datetime import date, datetime, time
78
from typing import Any
89

910
import pytest
@@ -336,19 +337,21 @@ def __init__(self, payload: dict):
336337

337338
assert container.to_dict()["payload"] == {"groups": [{"items": ["valid"]}]}
338339

339-
def test_to_dict_with_datetime_in_dict(self):
340-
"""Test to_dict converts datetime objects in dicts to strings."""
341-
from datetime import datetime
340+
@pytest.mark.parametrize("value", [datetime(2025, 1, 27, 12), date(2025, 1, 27), time(12)])
341+
def test_to_dict_only_converts_date_time_in_dict_values(self, value):
342+
"""Test to_dict preserves the existing date/time conversion contexts."""
342343

343344
class TestClass(SerializationMixin):
344-
def __init__(self, metadata: dict):
345-
self.metadata = metadata
345+
def __init__(self):
346+
self.top_level = value
347+
self.items = [value]
348+
self.metadata = {"created_at": value}
346349

347-
now = datetime(2025, 1, 27, 12, 0, 0)
348-
obj = TestClass(metadata={"created_at": now})
349-
data = obj.to_dict()
350+
data = TestClass().to_dict()
350351

351-
assert isinstance(data["metadata"]["created_at"], str)
352+
assert "top_level" not in data
353+
assert data["items"] == []
354+
assert data["metadata"]["created_at"] == str(value)
352355

353356
def test_to_dict_skips_non_serializable_in_dict(self, caplog):
354357
"""Test to_dict skips non-serializable values in dicts with debug logging."""

0 commit comments

Comments
 (0)