Repository navigation
Restore account balance when deleting transactions - #1927
Merged
Yohan Lasorsa (sinedied) merged 3 commits intoNov 9, 2026
Merged
Yohan Lasorsa (sinedied) merged 3 commits into
Yohan Lasorsa (sinedied) merged 3 commits into
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Quick follow-up, Yohan Lasorsa (@sinedied). Could you take a look at the banking example's transaction deletion fix when you have a chance? Thanks. |
Yohan Lasorsa (sinedied)
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm testcommand for the bank API.Problem
Creating a transaction updates
account.balance, but deleting the same transaction previously removed only the transaction entry. The API could therefore return a transaction history that no longer reconciled with its reported balance.For example, starting at 75, adding a +10 transaction produced 85. Deleting that transaction returned HTTP 204 and removed it from the ledger, but the balance remained 85.
Testing
Both commands pass against the published branch contents.