You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Allow localhost proxy for consomme when localhost forwarding is enabled - #42196
Problem: Consomme discarded reachable Windows loopback proxies because automatic proxy filtering only allowed them in mirrored mode.
Fix: Allow 127.0.0.1 proxies when Consomme localhost forwarding is enabled, preserve original settings across networking fallback, and update the rejection reason and warning.
PR Checklist
Closes: Link to issue #xxx
Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
Tests: Added/updated if needed and all pass
Localization: All end user facing strings can be localized
Dev docs: Added/updated if needed
Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
Detailed Description of the Pull Request / Additional comments
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Reusing the warning’s resource key preserves stale translations, causing German users to see a NAT-specific explanation when a Consomme proxy is rejected.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Reusing the warning’s resource key preserves outdated NAT-specific translations, and regression coverage does not verify restoration of the original proxy and bypasses after NAT-to-Consomme fallback.
Test proxy restoration after NAT-to-Consomme fallback
src/windows/service/exe/LxssHttpProxy.cpp:598
HttpProxyLoopback starts directly in Consomme and restarts the service between forwarding settings, so it never exercises restoration after networking fallback. Losing the retained originals would therefore leave that test passing while dropping the proxy and its bypasses during NAT-to-Consomme fallback. Please add a regression test that completes the initial query under NAT, switches the same tracker to Consomme with localhost relay enabled, and verifies that the original 127.0.0.1 proxy and bypasses are restored.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The existing test does not cover restoring filtered proxy settings on the same tracker after a NAT-to-Consomme transition, leaving loopback proxy and bypass restoration without regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Problem: Consomme discarded reachable Windows loopback proxies because automatic proxy filtering only allowed them in mirrored mode.
Fix: Allow 127.0.0.1 proxies when Consomme localhost forwarding is enabled, preserve original settings across networking fallback, and update the rejection reason and warning.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Add test:
NetworkTests::ConsommeTests::HttpProxyLoopback
NetworkTests::NetworkTests::HttpProxyRestoredAfterNatFallback
Also manually tested by setting up a localhost proxy on Windows and check that the proxy works correctly with consomme.