Repository navigation
Fix --exec using the wrong binary search path - #42194
Merged
Feng Wang (chemwolf6922) merged 1 commit intoNov 9, 2026
Merged
Feng Wang (chemwolf6922) merged 1 commit into
Feng Wang (chemwolf6922) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change to use the prepared launch environment’s PATH for executable lookup.
No open issues 🎉
What changed in this PR
This PR fixes executable lookup for wsl --exec so commands are searched using the prepared launch environment’s PATH, rather than init’s environment.
Changes:
- Assigns the launch environment to the final child’s
environbefore callingexecvpe(). - Adds an
ExecSearchPathregression test that creates a command in/usr/sbinand verifies--execfinds it.
| File | Description |
|---|---|
test/windows/wsl/UnitTests.cpp |
Adds the executable search-path regression test with cleanup. |
src/linux/init/init.cpp |
Makes executable lookup use the prepared launch environment. |
Review effort: Balanced
Blue (OneBlue)
approved these changes
Nov 6, 2026
AmirMS (AmelBawa-msft)
approved these changes
Nov 6, 2026
ggarzia-MSFT
approved these changes
Nov 6, 2026
Feng Wang (chemwolf6922)
deleted the
user/chemwolf6922/fix-exec-using-the-wrong-binary-search-path
branch
November 9, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Problem:
wsl --execcould fail to find commands present in the launch’s PATH because execvpe() searched init’s environment instead.Fix: Set the final child’s environ to the prepared launch environment before execvpe(), so executable lookup uses the correct PATH.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Add test:
UnitTests::UnitTests::ExecSearchPath