Repository navigation
Fix log packaging fallback logic - #42192
Merged
Feng Wang (chemwolf6922) merged 1 commit intoNov 9, 2026
Merged
Feng Wang (chemwolf6922) merged 1 commit into
Feng Wang (chemwolf6922) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The diagnostic log packaging changes have no active review issues.
No open issues 🎉
What changed in this PR
This PR hardens diagnostic log packaging so a missing or failing tar.exe does not cause unarchived logs to be deleted or success to be falsely reported.
Changes:
- Catches tar failures and falls back to ZIP compression.
- Treats ZIP errors as failures and checks that the archive exists before deleting source logs.
- Preserves the collected logs when both compression methods fail.
| File | Description |
|---|---|
diagnostics/collect-wsl-logs.ps1 |
Adds guarded compression fallback and centralizes success reporting and cleanup. |
Review effort: Balanced
Blue (OneBlue)
approved these changes
Nov 6, 2026
AmirMS (AmelBawa-msft)
approved these changes
Nov 6, 2026
Feng Wang (chemwolf6922)
deleted the
user/chemwolf6922/fix-log-packaging-fallback-logic
branch
November 9, 2026 02:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Issue: Missing tar.exe left $LASTEXITCODE unchanged, so a previous zero could cause unarchived logs to be deleted and success falsely reported.
Fix: Catch tar failures and fall back to ZIP, treat ZIP errors as failures, and verify archive creation before deleting logs. Preserve the logs if both methods fail.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed