Repository navigation
wslc: fix build by porting ObjectId argument to ArgumentOverrides syntax - #41497
Closed
ggarzia-MSFT wants to merge 1 commit into
Closed
ggarzia-MSFT wants to merge 1 commit into
ggarzia-MSFT wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward, verified mechanical port that resolves the stated compile failure without altering the test’s intended behavior.
Pull request overview
Fixes a build break in the wslc CLI unit tests caused by an API change to Argument::Create, by updating the remaining call site to use the newer ArgumentOverrides syntax.
Changes:
- Update
WSLCCLIParserUnitTests.cppto constructArgType::ObjectIdwithArgumentOverrides(porting.Limit = Limit::Unlimited).
File summaries
| File | Description |
|---|---|
| test/windows/wslc/WSLCCLIParserUnitTests.cpp | Ports the last outdated Argument::Create call to ArgumentOverrides to restore compilation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AmirMS (AmelBawa-msft)
approved these changes
Sep 1, 2026
AmirMS (AmelBawa-msft)
enabled auto-merge (squash)
September 1, 2026 20:16
David Bennett (dkbennett)
approved these changes
Sep 1, 2026
Member
|
Heh, beat you by one minute ;) |
Contributor
Author
|
Closing due to duplicate: #41496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
masterdoes not currently compile. Two independently-correct PRs combined into a semantic merge conflict:8544b7b0, alias-fto--formaton inspect commands) added a test that callsArgument::Createusing the old positional signatureCreate(type, required, limit, desc).2dbe9953, CLI: Add explicit per-command argument overrides) replaced that signature withCreate(ArgType type, ArgumentOverrides overrides = {})and ported every call site it was aware of.#41478 was validated against a base that predated #41463, and the two touch different lines, so git merged them with no textual conflict and no CI re-run. The result is a call site that cannot bind to any overload — there is only one
Createdeclaration, so a 3-argument call is unconditionally ill-formed:test\windows\wslc\WSLCCLIParserUnitTests.cpp(670,91): error C2660: 'wsl::windows::wslc::Argument::Create': function does not take 3 arguments while trying to match the argument list '(ArgType, bool, Limit)'
PR Checklist