Repository navigation
Follow up to the cgroup PR #40519 - #41073
Merged
Ben Hillis (benhillis) merged 5 commits intoJul 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR follows up on feedback from #40519 by simplifying a test helper’s std::format usage around wide-string inputs and by adding a user-facing warning when cgroup v1 is enabled in a configuration that indicates per-distribution cgroup isolation.
Changes:
- Remove a redundant wide→narrow conversion in
LxssWriteWslDistroConfig()by relying on the repo’sstd::formatter<const wchar_t*, char>specialization. - Emit a user warning when cgroup v1 is selected while a per-distro cgroup path is present (indicating isolation is in effect).
- Add the corresponding en-US localized string for the new warning message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/windows/Common.cpp | Simplifies path formatting by formatting LPCWSTR directly into a narrow std::format string. |
| src/linux/init/config.cpp | Adds an EMIT_USER_WARNING when cgroup v1 is requested alongside per-distro isolation context. |
| localization/strings/en-US/Resources.resw | Adds a new localized resource string for the cgroup v1 incompatibility warning. |
Blue (OneBlue)
approved these changes
Jul 23, 2026
Ben Hillis (benhillis)
deleted the
user/chemwolf6922/cgroup-change-followup
branch
July 24, 2026 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR serves as a follow up to comments in #40519
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed