Skip to content

Ignore GSL warning - #40560

Merged
JohnMcPMS merged 2 commits into
microsoft:masterfrom
JohnMcPMS:vm-term-event
May 15, 2026
Merged

JohnMcPMS merged 2 commits into
microsoft:masterfrom
JohnMcPMS:vm-term-event

Conversation

@JohnMcPMS

Copy link
Copy Markdown
Member

Summary of the Pull Request

Ignore a new GSL warning that causes a build break on the latest VS 2022 compiler release.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

GSL headers are included in multiple locations throughout the code and this warning number appears to be targeted to this scenario tightly. Ignored globally until a new release of GSL brings in the fix.

Validation Steps Performed

Built.

Copilot AI review requested due to automatic review settings May 15, 2026 19:27
@JohnMcPMS
JohnMcPMS requested a review from a team as a code owner May 15, 2026 19:27
@JohnMcPMS
JohnMcPMS merged commit 2933bff into microsoft:master May 15, 2026
13 checks passed
@JohnMcPMS
JohnMcPMS deleted the vm-term-event branch May 15, 2026 22:05
Blue (OneBlue) added a commit that referenced this pull request Aug 14, 2026
* Mount plugin folders on behalf of the user owning the wsl session (#41331)

* Ignore GSL warning (#40560)

* Use an azure key vault to store Github tokens for automated pull requests & release creation (#41158)

* Experiment with keyvault

* Iterate

* Iterate

* Prepare for PR

* Fix bad merge

---------

Co-authored-by: JohnMcPMS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants