Add WSLA-specific class registration for virtio networking #13819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update wsldevicehost nuget package with new version that contains the new class ID
benhillis
commented
Dec 3, 2025
|
|
||
| THROW_IF_WIN32_ERROR(NotifyNetworkConnectivityHintChange(&VirtioNetworking::OnNetworkConnectivityChange, this, true, &m_networkNotifyHandle)); | ||
| } | ||
| CATCH_LOG() |
Member
Author
There was a problem hiding this comment.
This was swallowing failures, I think it's probably better for initialize to throw instead of fail silently and leave the VM with partially configured networking.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds WSLA-specific class registration for virtio networking devices to enable separate packaging of the WSLA runtime from the main WSL MSI. The change introduces distinct class IDs for WSLA's virtio devices while maintaining compatibility with the shared wsldevicehost.dll implementation.
Key Changes:
- Introduced WSLA-specific GUID for virtio networking (
WSLA_VIRTIO_NET_CLASS_ID) - Refactored
VirtioNetworkingto accept a class ID parameter instead of using a static constant - Consolidated device type GUIDs (device IDs vs class IDs) into appropriate header files
- Added COM registration for WSLA's virtio network class in the MSI package
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/windows/wslaservice/exe/WSLAVirtualMachine.cpp |
Defines WSLA-specific virtio network class ID and passes it to VirtioNetworking constructor |
src/windows/service/exe/WslCoreVm.h |
Removes virtio FS class ID declarations (moved to .cpp file) |
src/windows/service/exe/WslCoreVm.cpp |
Defines WSL-specific virtio device class IDs and updates all references to use the new constants |
src/windows/common/VirtioNetworking.h |
Updates constructor signature to accept class ID parameter and makes it an instance member |
src/windows/common/VirtioNetworking.cpp |
Implements class ID as constructor parameter and removes function-try-block pattern |
src/windows/common/GuestDeviceManager.h |
Consolidates virtio device type GUIDs with consistent naming and comments |
src/windows/common/GuestDeviceManager.cpp |
Updates reference to use new VIRTIO_FS_DEVICE_ID constant name |
packages.config |
Updates Microsoft.WSL.DeviceHost package version |
msipackage/package.wix.in |
Adds COM registration for WSLA's virtio network class with dedicated AppID |
OneBlue
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates WSLA to use its own registration of wsldevicehost.dll and updates the virtio networking code to support running with either the WSL or WSLA versions of the class.
Currently since the WSLA service is part of the WSL MSI things were working fine, however when there is a separate package for the WSLA runtime a separate version of the wsldevicehost registration will be needed.