test: minor updates to improve virtiofs pass rate #13815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves two distinct issues preventing virtiofs tests from passing reliably:
- Fixed incorrect mmap error handling - Changed from
LxtCheckNullErrnotoLxtCheckMapErrnomacro and properly initialized the mapping pointer withMAP_FAILEDinstead ofNULL. This prevented segfaults when testing app execution aliases. - Updated test logic for virtiofs support - Added virtiofs-specific skip conditions to match existing plan9 behavior, and properly threaded the
DrvFsModeparameter to enable conditional test logic.
- Updated
DrvFsFattest to skip for VirtioFS (only supports full drive mounts) - Added virtiofs checks alongside plan9 in multiple test skip conditions
- Fixed initialization order to set config before launching WSL
- Updated comments to reflect virtiofs limitations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/windows/DrvFsTests.cpp | Added DrvFsMode parameter to DrvFsFat, added VirtioFS skip logic, fixed test setup initialization order to apply config before launching WSL |
| test/linux/unit_tests/drvfs.c | Fixed mmap error checking (LxtCheckMapErrno + MAP_FAILED), added virtiofs skip conditions matching plan9 behavior, updated comments |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
benhillis
force-pushed
the
user/benhill/virtiofs_test_updates
branch
from
0225078 to
d4eeadb
Compare
OneBlue
reviewed
Dec 2, 2025
OneBlue
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a few minor issues preventing some virtiofs tests from passing.