test: improve test logging infra #13811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
Brian-Perkins,
OneBlue,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two bugs in the test logging infrastructure to improve reliability and correctness of test result reporting. The changes prevent false positives from crashed test processes and fix incorrect printf format strings that were causing test names to be displayed as "null".
Key Changes
- Added explicit verification of test process exit codes to catch crashes that occur without prior error logging
- Fixed incorrect printf format strings in Linux unit test logging by removing extraneous
falsearguments - Changed test assertion approach from exception-based (
THROW_HR_IF) to framework-based (VERIFY_IS_TRUE) for better test failure reporting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/windows/Common.cpp | Captures exit code in variable for logging, adds VERIFY_ARE_EQUAL check on exit code, and changes THROW_HR_IF to VERIFY_IS_TRUE for test pass/fail verification |
| test/linux/unit_tests/unittests.c | Removes incorrect false arguments from LxtLogPassed and LxtLogError calls that were causing test names to print as "null" due to printf format mismatch |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
OneBlue
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a different test failure, I noticed two things: