virtio networking: fix two minor issues #13810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
Brian-Perkins,
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves two issues with virtio proxy networking mode: ensuring proper cleanup of the GNS channel during VirtioNetworking teardown, and fixing MTU propagation to the guest virtual adapter.
Key Changes
- Added explicit destructor to VirtioNetworking that calls
m_gnsChannel.Stop()to unblock any stuck guest communications - Implemented
GetMinimumConnectedInterfaceMtu()helper function to extract duplicated MTU calculation logic into a reusable, properly namespaced function - Fixed critical bug in VirtioNetworking::UpdateMtu() where
m_networkMtuwas never updated, causing incorrect MTU values (always 0) to be used - Uncommented and fixed the MTU notification sending in VirtioNetworking (was using non-existent
m_endpointIdinstead ofm_adapterId)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/windows/common/WslCoreNetworkingSupport.h | Added declaration for GetMinimumConnectedInterfaceMtu() helper function with documentation |
| src/windows/common/WslCoreNetworkingSupport.cpp | Implemented GetMinimumConnectedInterfaceMtu() to extract common MTU calculation logic with proper error handling |
| src/windows/common/VirtioNetworking.h | Changed destructor from default to explicit declaration to enable cleanup logic |
| src/windows/common/VirtioNetworking.cpp | Added destructor implementation with GNS channel stop; fixed UpdateMtu() to actually update m_networkMtu and send notifications with correct adapter ID |
| src/windows/common/NatNetworking.cpp | Refactored UpdateMtu() to use new GetMinimumConnectedInterfaceMtu() helper, reducing code duplication |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
OneBlue
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves two minor issues with the virtio proxy networking mode.