Skip to content

Comments

Add resize observer#948

Merged
orta merged 9 commits intomicrosoft:masterfrom
timocov:add-resize-observer
Dec 12, 2020
Merged

Add resize observer#948
orta merged 9 commits intomicrosoft:masterfrom
timocov:add-resize-observer

Conversation

@timocov
Copy link
Contributor

@timocov timocov commented Oct 26, 2020 •
edited
Loading

This PR is based on #847, but with replacing the sequence type with FrozenArray (see #847 (comment), #847 (comment), w3c/webidl2.js#392 (comment)).

I'm not sure whether it's correct to do so in this way, but it seems that #847 is inactive so far and I'm not sure why we can't change the type according the drafts.

Please let me know if I did something wrong and/or close this PR if required.

fixes microsoft/TypeScript#37861
fixes #908

@timocov timocov marked this pull request as ready for review October 26, 2020 10:17
@timocov timocov requested a review from sandersn as a code owner October 26, 2020 10:17
saschanaz
saschanaz reviewed Oct 26, 2020
View reviewed changes
saschanaz
saschanaz reviewed Oct 26, 2020
View reviewed changes
saschanaz
saschanaz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note that merging this may take some time as AFAIK it typically happens when new TS release is about to happen.

@mdingena
Copy link

mdingena commented Oct 27, 2020 •
edited
Loading

Thanks for being proactive and get things moving again. 👏 I'm looking forward to seeing this merged!

Perhaps add some closing keywords in the PR description to close the other issue and the inactive PR once this one gets merged?

@anandtiwary anandtiwary mentioned this pull request Nov 7, 2020
Merged
This was referenced Nov 7, 2020
Merged
Closed
@claviska claviska mentioned this pull request Nov 18, 2020
Closed
@anandtiwary
Copy link

anandtiwary commented Nov 20, 2020

@sandersn can we merge this?

@Earlo Earlo mentioned this pull request Nov 21, 2020
Merged
Earlo added a commit to RikuLa/lucky-wheel that referenced this pull request Nov 21, 2020
@Earlo
Ignore line until microsoft/TypeScript-DOM-lib-generator#948 is merged
5aea5cd
@EricRabil
Copy link

EricRabil commented Dec 4, 2020

@saschanaz there's been a few releases since your previous comment, is there any update on when this will be merged?

@saschanaz
Copy link
Collaborator

saschanaz commented Dec 4, 2020

By new release I mean a new minor version bump. I don't have any further information unfortunately.

timocov added a commit to tradingview/lightweight-charts that referenced this pull request Dec 10, 2020
@timocov
Sync ResizeObserver types with generated by TypeScript-DOM-lib-generator
6e63068 
See microsoft/TypeScript-DOM-lib-generator#948
sandersn
sandersn approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Once it's merged from master, it's ready to go in.

@timocov
Copy link
Contributor Author

timocov commented Dec 11, 2020

Just merged master branch with resolving conflicts.

@orta
Copy link
Contributor

orta commented Dec 12, 2020

Thanks!

@orta orta merged commit 3143838 into microsoft:master Dec 12, 2020
@timocov timocov deleted the add-resize-observer branch December 12, 2020 12:40
@wKich wKich mentioned this pull request May 11, 2021
Closed
5 tasks
@coryrylan coryrylan mentioned this pull request Jun 14, 2021
Closed
@cee-chen cee-chen mentioned this pull request Mar 18, 2024
Merged
@9romise 9romise mentioned this pull request Oct 30, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandersn sandersn sandersn approved these changes

+2 more reviewers

@a-tarasyuk a-tarasyuk a-tarasyuk approved these changes

@saschanaz saschanaz saschanaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing API: ResizeObserver ResizeObserver API declarations missing

9 participants

@timocov @mdingena @anandtiwary @EricRabil @saschanaz @orta @sandersn @a-tarasyuk @manucorporat